native simulator drivers coding guidelines fixes #89741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a copyright line to comply with the coding guidelines. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
Don't use the same name for the structure instance and type. As that is a violation of MISRA-C 2012 rule 5.7. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
added
the
Trivial
github-actions
bot
added
area: Ethernet
area: native port
github-actions
bot
requested review from
a user,
ceolin,
decsny,
lmajewski,
maass-hamburg,
nordic-krch,
pdgendt and
tomi-font
Don't use the same name for the structure instance and type. As that is a violation of MISRA-C 2012 rule 5.7. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
pdgendt
approved these changes
May 9, 2025
carlescufi
approved these changes
May 9, 2025
|
nashif
approved these changes
May 9, 2025
bjarki-andreasen
approved these changes
May 9, 2025
maass-hamburg
approved these changes
May 9, 2025
Member
Author
|
Replacing assignee, as both counter and ethernet areas were equally changed in a trivial way either maintainer would be equally ok (no need to waste more reviewers time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for 3 trivial coding guidelines violations found downstream.
There is no functional changes