scripts: runners: nrfutil: Check return code after Popen #89742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Failures are new, will need to rework the test cases for nrfutil. |
The code invoking nrfutil was not checking the return code of the subprocess, which meant that if the underlying tool was exiting with a failure error code it remained undetected. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
force-pushed
the
nrfutil-check-retcode
branch
from
9a62bbc to
1eca1f9
Compare
|
pdgendt
approved these changes
May 12, 2025
anangl
approved these changes
May 12, 2025
kartben
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code invoking nrfutil was not checking the return code of the subprocess, which meant that if the underlying tool was exiting with a failure error code it remained undetected.