-
Notifications
You must be signed in to change notification settings - Fork 8.4k
tests: drivers: mbox: mbox_data: add support for s32z #89798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: drivers: mbox: mbox_data: add support for s32z #89798
Conversation
6cbc692 to
c6a88c2
Compare
|
Hello @kartben, Could you please take a look at my PR? Thanks! |
While it's technically possible to send a message from a CPU to itself, that's not a typical or very meaningful use case -especially in the context of a sample. Mailbox peripherals like the MRU are generally intended for inter-CPU communication. This implementation feels more like an internal test case rather than functionality that should be demonstrated in a generic Zephyr sample. |
c6a88c2 to
4cf05d0
Compare
Yes, this implementation is internal and specific to the NXP S32 SoC. Therefore, I created an internal test for the NXP S32 SoC instead of doing in the generic Zephyr test. |
By internal I really meant, internal, as not on this Github repo :) I fail to see the benefit of having an NXP sample for the mailbox driver where a CPU send msgs to itself. We could have maybe two Zephyr apps exchanging msgs through the mailbox, it would make more sense. If the mbox maintainers think this is useful, please keep it in the generic sample as you originally did. I can only advise from the NXP S32 pov. |
kartben
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What @manuargue said, basically. It's really not clear why this new sample would be needed.
4cf05d0 to
b9192a5
Compare
|
Hello @kartben, @manuargue, I have updated the change to remove the sample I created. I retained support for tests/drivers/mbox/mbox_data and this test is modified to support loopback test. |
tests/drivers/mbox/mbox_data/Kconfig
Outdated
| Include remote build header files. Can be used if primary image | ||
| needs to be aware of size or base address of secondary image | ||
|
|
||
| config TEST_LOOPBACK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no such thing as loopback for the mailboxes. I'd rather call this TEST_SINGLE_CPU or the like, and explain the CPU sends a msg to itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated to change the name of kconfig
b9192a5 to
1981e99
Compare
The hardware MRU on SoC S32Z supports ping-pong data on a MBOX channel within one core. Added Kconfig TEST_SINGLE_CPU to enable test on single CPU to wrap the specific code for each testcase, As the expected received data must match the sent data when running test single CPU. This differs from the expected data in the current supported test transfer data between 2 other cores, where the remote core increments the data by one before transferring it back to the main core. Signed-off-by: Cong Nguyen Huu <cong.nguyenhuu@nxp.com>
1981e99 to
e79ed41
Compare
|
|
Hello @kartben , could you please revisit this PR? thanks. |



Added support for S32Z, ping-pong loopback data on a MBOX channel within one core.
The expected received data must match the sent data when running the sample.
The result for tests/drivers/mbox/mbox_data on s32z2xxdc2/s32z270/rtu0: