modem_cellular: Add dormant state to support network loss #89820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PPP net_if is changed to dormant, the PPP connection is terminated asynchronously. This is used so that the driver can terminate the PPP connection gracefully. Note: net_if_down() is not used as it would require synchronous operation which would block the system workqueue thus causing deadlock. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
github-actions
bot
requested review from
jukkar,
pdgendt,
rerickson1,
rlubos,
ssharks and
tbursztyka
rerickson1
previously approved these changes
May 12, 2025
pdgendt
reviewed
May 12, 2025
Contributor
pdgendt
left a comment
pdgendt
left a comment
There was a problem hiding this comment.
Couple of indentation nits
bjarki-andreasen
previously approved these changes
May 12, 2025
Previously, it was expected that the modem would immediately disconnect and close the PPP link, when the network was lost (+CEREG: 4 is received). Failure to do so, would result in modem attempting to chat with dlci2 channel, where as cellular modem driver would drop to dlci1. This would show as dial script timing out, which would freeze cellular modem driver. Adding dormant state enables graceful disconnection of PPP-link when the network is lost. This allows the modems which do not automatically close with network link loss to close based on PPP link closure. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
MarkusLassila
dismissed stale reviews from bjarki-andreasen and rerickson1
via
ec6bf18
MarkusLassila
force-pushed
the
upstream-zephyr-cellular-modem-fix-network-loss
branch
from
7dda543 to
ec6bf18
Compare
|
bjarki-andreasen
approved these changes
May 13, 2025
jukkar
approved these changes
May 13, 2025
rerickson1
approved these changes
May 13, 2025
Contributor
|
I think you accidentally removed the body of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was expected that the modem would immediately disconnect and close the PPP link, when the network was lost
(+CEREG: 4 is received). Failure to do so, would result in modem attempting to chat with dlci2 channel, where as cellular
modem driver would drop to dlci1. This would show as dial script timing out, which would freeze cellular modem driver.
Adding dormant state enables graceful disconnection of PPP-link when the network is lost. This allows the modems which do
not automatically close with network link loss to close based on PPP link closure.