drivers: misc: nordic_vpr_launcher: move SoC-specific config to DT #89824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Targets that require setting secure attribute to VPR should specify it in devicetree. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
Application cores should be next to eachother. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
github-actions
bot
added
platform: nRF
github-actions
bot
requested review from
VynDragon,
anangl,
carlocaione,
edersondisouza,
fkokosinski,
jaz1-nordic,
katsuster,
kgugala,
kl-cruz,
magp-nordic,
mgielda,
nika-nordic,
npitre,
tgorochowik and
ycsin
|
anangl
approved these changes
May 27, 2025
ycsin
reviewed
May 28, 2025
Comment on lines
+29
to
+32
| enable-secure: | ||
| type: boolean | ||
| description: | | ||
| Enables setting VPR core's secure attribute to secure. |
Member
There was a problem hiding this comment.
Looks like a feature switch and thus should be done with Kconfig instead?
Contributor
Author
There was a problem hiding this comment.
It's HW's initial configuration.
jaz1-nordic
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets that require setting secure attribute to VPR should specify
it in devicetree.
Also, fix ordering in Kconfig.