net: mqtt-sn: Correct the allowed Keep Alive value range #89825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep Alive timeout is represented by 2-byte unsigned integer, however the corresponding Kconfig option was limited to UINT8_MAX only. Also, similarly to regular MQTT, allow to disable the Keep Alive functionality by specifying the Keep Alive value to 0. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
github-actions
bot
requested review from
BeckmaR,
jukkar,
pdgendt,
ssharks and
tbursztyka
|
pdgendt
approved these changes
May 12, 2025
maass-hamburg
approved these changes
May 12, 2025
BeckmaR
approved these changes
May 12, 2025
jukkar
approved these changes
May 13, 2025
Closed
kartben
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep Alive timeout is represented by 2-byte unsigned integer, however the corresponding Kconfig option was limited to UINT8_MAX only. Also, similarly to regular MQTT, allow to disable the Keep Alive functionality by specifying the Keep Alive value to 0.
Fixes #89684