net: dns: dispatcher: fix OOB array access #89827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate that the file descriptor is not a negative number before writing to the `dispatch_table` `ctx` field. Setting file descriptors to `-1` is the standard "not in use" value, and in fact the entire array of `fds` is set to this value in `dns_resolve_init_locked`. This resolves memory corruption of whichever variable is unfortunate to exist just before `dispatch_table` in memory. Signed-off-by: Jordan Yates <jordan@embeint.com>
github-actions
bot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
|
rlubos
approved these changes
May 12, 2025
pdgendt
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that the file descriptor is not a negative number before writing to the
dispatch_tablectxfield. Setting file descriptors to-1is the standard "not in use" value, and in fact the entire array offdsis set to this value indns_resolve_init_locked. This resolves memory corruption of whichever variable is unfortunate to exist just beforedispatch_tablein memory.