dma: intel_adsp_hda: re-enable interrupts upon resume #89830
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression by re-enabling the interrupt configuration on resume for the Intel ADSP HDA DMA driver. It introduces a helper function (intel_adsp_hda_enable_irqs) to centralize the irq configuration and updates both channel initialization and power management resume actions to call this helper.
|
@tmleman Please take a look. I've confirmed I see "ie[ACE_INTL].HODMA" not set on ace30 without this PR, so a suspend/resume cycle breaks the L1-exit isr logic and interrupts stop being delivered (they work initially e.g. for external module loads, but then stop). FYI @abonislawski |
|
FYI @tmleman @abonislawski this seems to be related to context save. I could reproduce this issue on ACE1.5 with CONFIG_ADSP_IMR_CONTEXT_SAVE=y (it's disabled by default in upstream). |
Commit fa4a9db ("dma: intel_adsp_hda: Fix invalid init sequence and register use") moved intel_adsp_hda_channels_init() out from resume path. This causes a regression to CONFIG_DMA_INTEL_ADSP_HDA_TIMING_L1_EXIT as without irq_config() call the interrupt configuration may be partial. Address this by calling irq_config() unconditionally on resume path. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
dismissed stale reviews from nashif, teburd, tmleman, serhiy-katsyuba-intel, and abonislawski
via
7fc8573
kv2019i
force-pushed
the
202505-hda-dma-fix-irq-renable-on-resume
branch
from
1579064 to
7fc8573
Compare
|
New version:
|
Context save changes the flow during booting. The driver's init function is called during kernel startup. If |
|
7 participants
Commit fa4a9db ("dma: intel_adsp_hda: Fix invalid init sequence and register use") moved intel_adsp_hda_channels_init() out from resume path. This causes a regression to CONFIG_DMA_INTEL_ADSP_HDA_TIMING_L1_EXIT as without irq_config() call the interrupt configuration may be partial.
Address this by calling irq_config() unconditionally on resume path.