samples: Bluetooth: BAP: BA: Reset states and modify error checking #89835
+89
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
bap_broadcast_assistant_loop_fix
branch
from
7b37db5 to
b0bb06a
Compare
github-actions
bot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
kartben,
larsgk,
nashif,
niym-ot,
pin-zephyr and
sjanc
Thalley
force-pushed
the
bap_broadcast_assistant_loop_fix
branch
from
b0bb06a to
9ac999f
Compare
koffes
approved these changes
Jun 10, 2025
| } | ||
|
|
||
| /* Ignore return value as scanning may already be stopped */ | ||
| (void)bt_le_scan_stop(); |
Contributor
There was a problem hiding this comment.
Nit: May want to check for -EALREADY.
Contributor
Author
There was a problem hiding this comment.
I did consider that, but as far as I can tell, the function does not return -EALREADY if not scanning.
I guess it's related to this part in the BT Core spec:
Disabling scanning when it is disabled has no effect.
Thalley
force-pushed
the
bap_broadcast_assistant_loop_fix
branch
from
9ac999f to
37f9989
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves the reset functionality and error handling for Bluetooth Broadcast Assistant operations by resetting connection and PA sync states, adding proper mutex and semaphore checks, and cleaning up text and error messages.
- Updated error checking using __ASSERT_NO_MSG and refined semaphore timeouts
- Added missing include directives and relocated variable declarations to ensure proper reset behavior
- Modified the reset function to better handle disconnection and PA sync termination events
Comments suppressed due to low confidence (1)
samples/bluetooth/bap_broadcast_assistant/src/main.c:75
- The semaphore 'sem_pa_sync_terminted' appears to have a typo; consider renaming it to 'sem_pa_sync_terminated' for clarity and consistency.
static K_SEM_DEFINE(sem_pa_sync_terminted, 0, 1);
Modify the reset function to also reset the connection and PA sync states. Modify and add missing checks for mutex locks to use ASSERT when using K_FOREVER, as they should never fail/timeout. Cleanup some text and error checks. Ensure that the add_src_param is reset for each loop iteration as well. Modify so that we use K_FOREVER fewer places. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
bap_broadcast_assistant_loop_fix
branch
from
37f9989 to
ebdb3a6
Compare
|
babrsn
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the reset function to also reset the connection and PA sync states.
Modify and add missing checks for mutex locks to use ASSERT when using K_FOREVER, as they should never fail/timeout.
Cleanup some text and error checks.
Ensure that the add_src_param is reset for each loop iteration as well.