Skip to content

native targets: Fix a few trivialities found by sonarqubecloud #89844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kartben merged 7 commits into from
May 13, 2025
Merged

native targets: Fix a few trivialities found by sonarqubecloud #89844

kartben merged 7 commits into from
May 13, 2025

Conversation

@aescolar
Copy link
Member

@aescolar aescolar commented May 12, 2025 •
edited
Loading

Just trivialities with no functional impact.

aescolar added 6 commits May 12, 2025 14:52
@aescolar
arch/posix: Add comment on empty function
b028a10 
So it is clearer this kernel required API does not need to do anything.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
soc posix: Be explicit about wanting the function address
7aada19 
To be more readable

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
boards native: Move int declaration into loop
699b745 
To reduce its scope and please static analyzers

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
boards/native/nrf_bsim: Declare as pointer to constant data
1aa274e 
To be clearer to the compiler and users.

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers/timer/native_sim: Use upper case long suffix
e0dd1b1 
For better readability

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar
drivers/serial/uart_native_tty: do not discard const qualifier
9a2658e 
So it is clearer the data is not modified

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@github-actions github-actions bot added area: Timer Timer platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim area: native port Host native arch port (native_sim) area: UART Universal Asynchronous Receiver-Transmitter labels May 12, 2025
@github-actions github-actions bot requested review from andyross, dcpleung and teburd May 12, 2025 15:13
@aescolar
drivers/counter/counter_native_sim: Merge if statements
f5e2827 
To reduce the perceived code complexity

Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
@aescolar aescolar added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label May 12, 2025
@github-actions github-actions bot requested a review from nordic-krch May 12, 2025 15:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kartben kartben merged commit 5c959c6 into zephyrproject-rtos:main May 13, 2025
43 of 44 checks passed
@aescolar aescolar deleted the natsim_sonar branch May 13, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@dcpleung dcpleung dcpleung approved these changes

@andyross andyross Awaiting requested review from andyross

@teburd teburd Awaiting requested review from teburd

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

Assignees

@dcpleung dcpleung

Labels

area: Counter area: native port Host native arch port (native_sim) area: Timer Timer area: UART Universal Asynchronous Receiver-Transmitter platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aescolar @kartben @dcpleung