cmake: kconfig: auto-generate boolean board revision option #89859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
force-pushed
the
auto-generate-board-revision-kconfig
branch
from
d85650b to
8b22e45
Compare
github-actions
bot
added
area: Continuous Integration
area: Coding Guidelines
github-actions
bot
requested review from
57300,
carlescufi,
fabiobaltieri,
jeremybettis,
jfischer-no,
kartben,
keith-zephyr,
nashif,
nordicjm,
simhein,
stephanosio and
tejlmand
cfriedt
commented
May 13, 2025
cfriedt
force-pushed
the
auto-generate-board-revision-kconfig
branch
from
8b22e45 to
b4d71b5
Compare
pdgendt
reviewed
May 13, 2025
Automatically generate a boolean CONFIG_BOARD_REVISION_FOO=y Kconfig option based on e.g. CONFIG_BOARD_REVISION="foo". Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
auto-generate-board-revision-kconfig
branch
from
b4d71b5 to
e8ec28e
Compare
|
tejlmand
approved these changes
May 16, 2025
pdgendt
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generate a boolean
CONFIG_BOARD_REVISION_FOO=yKconfig option based on e.g.CONFIG_BOARD_REVISION="foo".The allows us to use conditional expressions with the C preprocessor and also allows us to use e.g.
if (IS_ENABLED(CONFIG_BOARD_REVISION_FOO)) ....Closes #89375