tests: drivers: spi: spi_controller_peripheral: show data on failure #89869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-piks
force-pushed
the
more_output_from_spi_controller_peripheral
branch
from
204d1c0 to
390fb4d
Compare
nordic-segl
approved these changes
May 13, 2025
nordic-piks
force-pushed
the
more_output_from_spi_controller_peripheral
branch
3 times, most recently
from
42a9686 to
159245e
Compare
adamkondraciuk
approved these changes
May 19, 2025
Contributor
Author
|
@tbursztyka Please have a look. |
tbursztyka
requested changes
May 26, 2025
nordic-piks
force-pushed
the
more_output_from_spi_controller_peripheral
branch
from
159245e to
f54977b
Compare
Contributor
Author
|
@tbursztyka Applied your comments, please have a look. |
nordic-piks
force-pushed
the
more_output_from_spi_controller_peripheral
branch
from
f54977b to
43e8c79
Compare
Show TX and RX data when there is mismatch. Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
nordic-piks
force-pushed
the
more_output_from_spi_controller_peripheral
branch
from
43e8c79 to
09eefea
Compare
|
Contributor
Author
|
@tbursztyka Any clue how to fix this SonarQube issue? |
tbursztyka
reviewed
May 30, 2025
| } | ||
|
|
||
| return memcmp(tx_data, rx_data, rx_len); | ||
| len = MIN(MIN(rx_len, tx_len), MIN(sizeof(rx_data), sizeof(tx_data))); |
Contributor
There was a problem hiding this comment.
shouldn't the min on rx_len, tx_len be sufficient?
Contributor
Author
There was a problem hiding this comment.
that was previous version which I added, still tool was complaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show TX and RX data when there is mismatch.