Skip to content

add GPIO support on i.MX 943 A-Core #89878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkalowsk merged 8 commits into from
Jun 12, 2025
Merged

add GPIO support on i.MX 943 A-Core #89878

dkalowsk merged 8 commits into from
Jun 12, 2025

Conversation

@JiafeiPan
Copy link
Contributor

@JiafeiPan JiafeiPan commented May 13, 2025 •
edited
Loading

This PR is to add GPIO support for i.MX 943 EVK A-Core and with some minimal board document fix.

@JiafeiPan JiafeiPan marked this pull request as draft May 13, 2025 10:24
@github-actions
Copy link

github-actions bot commented May 13, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 13, 2025
@JiafeiPan
dts: nxp_mimx943_a55: add GPIO device nodes
93292c8 
Added all GPIO device nodes in i.MX 943 Cortex-A Core SoC dts.

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
@JiafeiPan JiafeiPan force-pushed the develop/imx943-gpio branch from e93f1aa to 552b9d4 Compare June 5, 2025 02:31
@JiafeiPan JiafeiPan force-pushed the develop/imx943-gpio branch from 552b9d4 to 881ce19 Compare June 5, 2025 02:40
@JiafeiPan JiafeiPan marked this pull request as ready for review June 5, 2025 02:41
@JiafeiPan JiafeiPan requested review from yangbolu1991 and removed request for decsny June 5, 2025 02:42
@JiafeiPan JiafeiPan added this to the v4.2.0 milestone Jun 5, 2025
yangbolu1991
yangbolu1991 reviewed Jun 5, 2025
View reviewed changes
yangbolu1991
yangbolu1991 reviewed Jun 5, 2025
View reviewed changes
yangbolu1991
yangbolu1991 reviewed Jun 5, 2025
View reviewed changes
@yangbolu1991
Copy link
Member

yangbolu1991 commented Jun 5, 2025

May I know the reason to use default pad config value? Better to add in commit message.

drivers: gpio: rgpio: use default pad config value for SCMI platform

Thanks.

@JiafeiPan JiafeiPan force-pushed the develop/imx943-gpio branch from 881ce19 to 3d3d42c Compare June 6, 2025 03:05
@JiafeiPan
Copy link
Contributor Author

JiafeiPan commented Jun 6, 2025

May I know the reason to use default pad config value? Better to add in commit message.

drivers: gpio: rgpio: use default pad config value for SCMI platform

Thanks.

If the platform uses SCMI pinctrl driver, pinctrl regitster can't accessed by
CPU Core directly, and currently SCMI pinctrl driver has no API to read back
the register value, so use default pad config value for GPIO pad configuration,
and in theory we could use a fixed pad config value in this driver as each
new GPIO configuration has no relation with previous configuration.

Updated commit message.

@JiafeiPan JiafeiPan force-pushed the develop/imx943-gpio branch from 3d3d42c to 3e4f7f3 Compare June 6, 2025 09:02
JiafeiPan added 6 commits June 6, 2025 17:20
@JiafeiPan
drivers: gpio: rgpio: use default pad config value for SCMI platform
3757d04 
If the platform uses SCMI pinctrl driver, pinctrl regitster can't accessed
by CPU Core directly, and currently SCMI pinctrl driver has no API to read
back the register value, so use default pad config value for GPIO pad
configuration, and in theory we could use a fixed pad config value in this
driver as each new GPIO configuration has no relation with previous
configuration.

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
@JiafeiPan
drivers: gpio: rgpio: not support GPIO_DISCONNECTED
1d14160 
The hardware don't support GPIO_DISCONNECTED.

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
@JiafeiPan
tests: gpio: gpio_basic_api: config to input if disconnected not supp…
8e74f06 
…orted

If GPIO_DISCONNECTED is not supported by GPIO driver, then try to configure
the pin to be input, otherwise there will be some unstable signal between
two test pins.

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
@JiafeiPan
tests: gpio_basic_api: add imx943_evk_mimx94398_a55 overly
3ee80e4 
Add board overlay for i.MX943 EVK Cortex-A Core.

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
@JiafeiPan
boards: imx943_evk: fix document format issue
f5d6909 
Fixed the document format issue.

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
@JiafeiPan
boards: imx943_evk: add GPIO in supported list for A55
3e4f7f3 
Add GPIO in board yaml's supported list

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
yangbolu1991
yangbolu1991 previously approved these changes Jun 6, 2025
View reviewed changes
PetervdPerk-NXP
PetervdPerk-NXP reviewed Jun 6, 2025
View reviewed changes
@JiafeiPan
drivers: gpio: rgpio: only handle usable pin's interrupt
77ffaea 
If gpio-reserved-ranges to reserve some pins which used by other CPU
Core's OS, we could only handle usable pins owned by current CPU
Core in interrupt handler.

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 10, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
34.5% Duplication on New Code

See analysis details on SonarQube Cloud

@JiafeiPan JiafeiPan requested a review from yangbolu1991 June 11, 2025 01:47
@dkalowsk dkalowsk merged commit 47d6f02 into zephyrproject-rtos:main Jun 12, 2025
27 checks passed
@tiennguyenzg tiennguyenzg mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangbolu1991 yangbolu1991 yangbolu1991 approved these changes

@dleach02 dleach02 dleach02 approved these changes

@PetervdPerk-NXP PetervdPerk-NXP PetervdPerk-NXP approved these changes

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@carlocaione carlocaione Awaiting requested review from carlocaione

@dbaluta dbaluta Awaiting requested review from dbaluta

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@mnkp mnkp Awaiting requested review from mnkp

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@npitre npitre Awaiting requested review from npitre

@povergoing povergoing Awaiting requested review from povergoing

@Raymond0225 Raymond0225 Awaiting requested review from Raymond0225

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels

area: ARM64 ARM (64-bit) Architecture area: Clock Control area: GPIO platform: NXP Drivers NXP Semiconductors, drivers platform: NXP MPU platform: NXP NXP

Projects

None yet

Milestone

v4.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@JiafeiPan @yangbolu1991 @dleach02 @PetervdPerk-NXP @dkalowsk @mmahadevan108