Skip to content

Feature/unify to mcux sdk ng driver #89891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kartben merged 1 commit into from
May 15, 2025
Merged

Feature/unify to mcux sdk ng driver #89891

kartben merged 1 commit into from
May 15, 2025

Conversation

@zejiang0jason
Copy link
Contributor

@zejiang0jason zejiang0jason commented May 13, 2025

MCUX SDK NG drivers have been added in modules/hal/nxp, most boards have switched to use the SDK NG drivers.
To make the driver maintenance easy, switch all boards to use the MCUX SDK NG drivers.

@github-actions
Copy link

github-actions bot commented May 13, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@5e5a498 zephyrproject-rtos/hal_nxp@a961ce3 (master) zephyrproject-rtos/hal_nxp@5e5a498e..a961ce3b

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_nxp DNM (manifest) This PR should not be merged (controlled by action-manifest) labels May 13, 2025
carlescufi
carlescufi reviewed May 13, 2025
View reviewed changes
@zejiang0jason zejiang0jason force-pushed the feature/unify_to_mcux_sdk_ng_driver branch 3 times, most recently from 2ad0ae8 to b6762e0 Compare May 13, 2025 14:34
@dleach02
Copy link
Member

dleach02 commented May 13, 2025 •
edited
Loading

LGTM

@hakehuang can you provide feedback on HW range testing results?

@hakehuang
Copy link
Contributor

hakehuang commented May 14, 2025 •
edited
Loading

@hakehuang can you provide feedback on HW range testing results?

@dleach02 , board testing with v4.1.0-3851-gb6762e06ab23 done, no regression issue

dleach02
dleach02 previously approved these changes May 14, 2025
View reviewed changes
@zejiang0jason @dleach02
modules: hal_nxp: Unified to use SDK NG driver
02e59f3 
Some NXP boards are using legacy SDK driver, such as S32K, K64, MIMX8Q,
and so on. The legacy SDK driver will not be updated, migrate to use
SDK NG driver.

Signed-off-by: Jason Yu <zejiang.yu@nxp.com>
@dleach02 dleach02 force-pushed the feature/unify_to_mcux_sdk_ng_driver branch from b6762e0 to 02e59f3 Compare May 14, 2025 19:20
@dleach02
Copy link
Member

dleach02 commented May 14, 2025

HAL PR merged. @zejiang0jason I updated your west.yml manifest

@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label May 14, 2025
@dleach02 dleach02 closed this May 14, 2025
@dleach02 dleach02 reopened this May 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 14, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dleach02
Copy link
Member

dleach02 commented May 14, 2025

the SonarCloud item is on existing code that was not touched by this PR

@zejiang0jason
Copy link
Contributor Author

zejiang0jason commented May 15, 2025

The SonarCloud error seems is the script scripts/ci/check_compliance.py issue:
image

This PR touches this file, but the reported issue is an existing issue.

@kartben kartben merged commit c488c65 into zephyrproject-rtos:main May 15, 2025
47 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlescufi carlescufi carlescufi left review comments

@dleach02 dleach02 dleach02 approved these changes

@EmilioCBen EmilioCBen EmilioCBen approved these changes

@decsny decsny decsny approved these changes

@bperseghetti bperseghetti Awaiting requested review from bperseghetti

@manuargue manuargue Awaiting requested review from manuargue

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@PetervdPerk-NXP PetervdPerk-NXP Awaiting requested review from PetervdPerk-NXP

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@kartben kartben Awaiting requested review from kartben

@keith-zephyr keith-zephyr Awaiting requested review from keith-zephyr

@nashif nashif Awaiting requested review from nashif

@simhein simhein Awaiting requested review from simhein

@stephanosio stephanosio Awaiting requested review from stephanosio

Assignees

@mmahadevan108 mmahadevan108

@dleach02 dleach02

Labels

area: Coding Guidelines Coding guidelines and style area: Continuous Integration manifest manifest-hal_nxp platform: NXP NXP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zejiang0jason @dleach02 @hakehuang @carlescufi @EmilioCBen @decsny @kartben @mmahadevan108