NXP drivers: mcux gau adc: adds PM low power support #89904
Conversation
Suspend and standby should disable ADCs before entering low power. Signed-off-by: Alex Rodriguez <alejandro.rodriguezlimon@nxp.com>
github-actions
bot
added
area: ADC
github-actions
bot
requested review from
DerekSnell,
EmilioCBen,
Raymond0225,
anangl,
butok,
dbaluta,
decsny,
dleach02,
kartben,
manuargue,
mmahadevan108 and
nashif
alrodlim
force-pushed
the
feature/adc_mcux_gau_adc_enable_pm3
branch
2 times, most recently
from
b53ab2c to
19b2f50
Compare
drivers/adc/adc_mcux_gau_adc.c
Outdated
| /* Ideally we would return error here, but Zephyr API | ||
| * has no error for a failed calibration. | ||
| */ |
There was a problem hiding this comment.
this zephyr api might not explicitly say that "other negative value is error" , but most in zephyr do so I think it's okay to return error like -EIO in this case. It was probably just forgotten . In fact you could add it to the API docstring in this PR and I doubt there would be much problem. maintainer cc @anangl
alrodlim
force-pushed
the
feature/adc_mcux_gau_adc_enable_pm3
branch
from
19b2f50 to
f319b15
Compare
Enables sleep mode (PM3) on RW61x. The driver re-enables the ADC after wakeup and restores its state based on the configuration before low power is entered. Note that the driver re-enables the GAU after wakeup since it's not done automatically. Signed-off-by: Alex Rodriguez <alejandro.rodriguezlimon@nxp.com>
alrodlim
force-pushed
the
feature/adc_mcux_gau_adc_enable_pm3
branch
from
f319b15 to
c20b45c
Compare
Enables system PM and standby mode to test PM3 functionality. Signed-off-by: Alex Rodriguez <alejandro.rodriguezlimon@nxp.com>
Explicitly state that any returned negative value is an error Signed-off-by: Alex Rodriguez <alejandro.rodriguezlimon@nxp.com>
alrodlim
force-pushed
the
feature/adc_mcux_gau_adc_enable_pm3
branch
from
c20b45c to
b7cbb72
Compare
|
| * interval was too small. All requested samples are written | ||
| * in the buffer, but at least some of them were taken with | ||
| * an extra delay compared to what was scheduled. | ||
| * @retval <0 Any other negative value indicates an error condition. |
| case PM_DEVICE_ACTION_SUSPEND: | ||
| break; |
There was a problem hiding this comment.
If we are enabling device PM, then since ADC is one of the biggest power consumers of the whole chip, I think we should try to take power saving actions on suspend, maybe by disabling the module and/or gating it's clock.
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
@alrodlim , is there anything more that needs to be done from your end on this PR? |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
5 participants
Tested samples/drivers/adc/adc_dt on FRDM-RW612. Verified that the ADC state is restored after PM3 mode and the read data is consistent.