Skip to content

twister: Enable gathering footprint if test plan exists #89945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danieldegrasse merged 1 commit into from
Jul 1, 2025
Merged

twister: Enable gathering footprint if test plan exists #89945

danieldegrasse merged 1 commit into from
Jul 1, 2025

Conversation

@katgiadla
Copy link
Contributor

@katgiadla katgiadla commented May 14, 2025

If test plan is used, memory usage metrics are overridden. Result of this operation is missing memory footprint.

This change removes redundand metrics update and fixes described inconvenience.

@katgiadla katgiadla requested review from PerMac, gchwier and nashif May 14, 2025 13:50
@katgiadla katgiadla added the area: Twister Twister label May 14, 2025
@github-actions github-actions bot added the size: XS A PR changing only a single line of code label May 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hakehuang
Copy link
Contributor

hakehuang commented May 15, 2025

If test plan is used, memory usage metrics are overridden. Result of this operation is missing memory footprint.

This change removes redundand metrics update and fixes described inconvenience

can you specify how to reproduce the failure?

@katgiadla
Copy link
Contributor Author

katgiadla commented May 15, 2025 •
edited
Loading

can you specify how to reproduce the failure?

Sure, below are atttached steps to reproduction:

  1. generate sample test plan
  2. run command: $ZEPHYR_BASE/scripts/twister -T tests/kernel/common/ -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id
  3. run command $ZEPHYR_BASE/scripts/twister --load-tests sample_testplan.json -T tests/kernel/common/ -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id (sample_testplan.json comes from previous step)
  4. compare twister report files (twister.json)

hakehuang
hakehuang reviewed May 16, 2025
View reviewed changes
@katgiadla katgiadla force-pushed the instancies_footprint branch from 31d8425 to 0ae056b Compare June 18, 2025 11:39
@katgiadla
twister: Enable gathering footprint if test plan exists
ab8ef8e 
If test plan is used, memory usage metrics are overridden.
Result of this operation is missing memory footprint.

This change removes redundand metrics update and fixes
described inconvenience.

Signed-off-by: Katarzyna Giądła <katarzyna.giadla@nordicsemi.no>
@katgiadla katgiadla force-pushed the instancies_footprint branch from 0ae056b to ab8ef8e Compare June 20, 2025 15:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@katgiadla katgiadla requested a review from hakehuang June 20, 2025 23:03
@katgiadla
Copy link
Contributor Author

katgiadla commented Jun 23, 2025

@nashif, @golowanow, @LukaszMrugala please check the changes :)

@nashif
Copy link
Member

nashif commented Jun 24, 2025

Sure, below are atttached steps to reproduction:

  1. generate sample test plan
  2. run command $ZEPHYR_BASE/scripts/twister --load-tests sample_testplan.json -T tests/kernel/common/ -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id
  3. run command: $ZEPHYR_BASE/scripts/twister -T tests/kernel/common/ -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id
  4. compare twister report file (twister.json)

not able to reproduce the issue, can you please be more detailed, i..e how do you generate the test plan?

@katgiadla
Copy link
Contributor Author

katgiadla commented Jun 24, 2025 •
edited
Loading

Sure, below are atttached steps to reproduction:

  1. generate sample test plan
  2. run command $ZEPHYR_BASE/scripts/twister --load-tests sample_testplan.json -T tests/kernel/common/ -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id
  3. run command: $ZEPHYR_BASE/scripts/twister -T tests/kernel/common/ -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id
  4. compare twister report file (twister.json)

not able to reproduce the issue, can you please be more detailed, i..e how do you generate the test plan?

@nashif I've used created test plan from case without test plan.

@PerMac
Copy link
Member

PerMac commented Jun 30, 2025

@nashif to reproduce:

  1. scripts/twister -T samples/hello_world/ -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id --save-tests testplan.json
  2. scripts/twister --load-tests testplan.json -p nrf52840dk/nrf52840 --enable-size-report --no-detailed-test-id
  3. Look at twister-out/twister.json for ram/rom footprints with and without the PR

@nashif nashif added this to the v4.2.0 milestone Jul 1, 2025
@danieldegrasse danieldegrasse merged commit bec789d into zephyrproject-rtos:main Jul 1, 2025
39 checks passed
@katgiadla katgiadla deleted the instancies_footprint branch July 3, 2025 10:06
@gchwier gchwier mentioned this pull request Jul 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nashif nashif nashif approved these changes

@hakehuang hakehuang hakehuang approved these changes

@PerMac PerMac PerMac approved these changes

@gchwier gchwier gchwier approved these changes

@golowanow golowanow Awaiting requested review from golowanow

@KamilxPaszkiet KamilxPaszkiet Awaiting requested review from KamilxPaszkiet

@LukaszMrugala LukaszMrugala Awaiting requested review from LukaszMrugala

Assignees

@nashif nashif

Labels

area: Twister Twister size: XS A PR changing only a single line of code

Projects

None yet

Milestone

v4.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@katgiadla @hakehuang @nashif @PerMac @gchwier @danieldegrasse