Skip to content

Conversation

@asmellby
Copy link
Contributor

.dtsi files for Silicon Labs SoCs are mixed together in a single directory covering 5 generations of SoCs with 3 completely different lineages. Within Series 2, naming is also inconsistent, and .dtsi files are not separated in a way that makes them reusable or composable.

This PR cleans up the Series 2 .dtsi files by structuring them as follows:

  • One directory per generic family (xg22/ = series 2 config 2)
  • One base .dtsi file describing the MCU part of the device (xg22.dtsi -- shareable across pg22 MCUs and bg22/fg22/mg22 RF MCUs)
  • One .dtsi file adding radio capability to the base file (efr32xg22.dtsi -- shareable between bg22/fg22/mg22 RF MCUs)
  • If not all radio capable devices support all RF protocols, one .dtsi file per device family (ef32bg22.dtsi)
  • SoC specific .dtsi files with specific peripheral capabilities, flash and ram size, etc

Boards continue to include the SoC-specific .dtsi file.

While each generic family modified in this PR currently only contains a single series, there are pending PRs for adding

@jerome-pouiller
Copy link
Contributor

Don't you think we should introduce efr32xg21.dtsi, efr32mg22.dtsi, etc... Even if these files only include the parent .dtsi, it would help to keep things consistent?

asmellby added 5 commits May 15, 2025 07:29
Introduce subdirectory for xg21 socs.

Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Introduce subdirectory for xg22 socs.

Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Introduce subdirectory for xg23 socs.

Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Introduce subdirectory for xg24 socs.

Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
Introduce subdirectory for xg27 socs.

Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
@asmellby asmellby force-pushed the feature/series2-dts-restructure branch from 0f5261a to 50ee4e0 Compare May 15, 2025 05:42
@asmellby
Copy link
Contributor Author

Don't you think we should introduce efr32xg21.dtsi, efr32mg22.dtsi, etc... Even if these files only include the parent .dtsi, it would help to keep things consistent?

Works for me.

jhedberg
jhedberg previously approved these changes May 15, 2025
Align xg29 directory with other Series 2 families, introducing
separate .dtsi files per device family inheriting the common
xg29.dtsi file.

Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
@asmellby asmellby force-pushed the feature/series2-dts-restructure branch from 50ee4e0 to ebc7416 Compare May 15, 2025 07:43
jhedberg
jhedberg previously approved these changes May 15, 2025
* SPDX-License-Identifier: Apache-2.0
*/

#include <silabs/xg24/efr32xg24.dtsi>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curiosity, what efr32bg24.dtsi will looks like?

Copy link
Contributor Author

@asmellby asmellby May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical for now. Once 802.15.4 support is implemented, it will be a child node of the radio in efr32mg24.dtsi and not in efr32bg24.dtsi.

@yishai1999
Copy link
Contributor

Big like

@jerome-pouiller
Copy link
Contributor

Should we place somewhere in the tree the explanations you provide in the PR description? Maybe in the same vein than boards/silabs/index.rst?

Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably needs a mention in migration guide since out-of-tree boards will be impacted

Describe changes users need to do in their out of tree board definitions
after the SoC DTS files have been moved into subdirectories.

Signed-off-by: Aksel Skauge Mellbye <aksel.mellbye@silabs.com>
@github-actions github-actions bot added the Release Notes To be mentioned in the release notes label May 16, 2025
@sonarqubecloud
Copy link

@kartben kartben merged commit b633265 into zephyrproject-rtos:main May 16, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Silabs Silicon Labs Release Notes To be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants