Skip to content

Conversation

@Liam-qk
Copy link
Contributor

@Liam-qk Liam-qk commented May 15, 2025

When try to set twt, system will try to
get interface status firstly.
In shim driver, miss filling twt_capable field.
The twt_capable is set as false by default.
Failed to set twt because of incorrect
twt_capable.

Add enhance code to fill twt_capable field
in shim driver.

@Liam-qk
Copy link
Contributor Author

Liam-qk commented May 15, 2025

Build errors of twister-build(1) and twister-build(7) are:
/__w/zephyr/zephyr/drivers/wifi/nxp/nxp_wifi_drv.c:1233:63: error: 'struct wlan_network' has no member named 'twt_capab'
1233 | status->twt_capable = nxp_wlan_network.twt_capab;
| ^

twt_capab is a newly added field in NXP Wi-Fi driver.
Will rebase this PR after NXP Wi-Fi driver synced.

MaochenWang1
MaochenWang1 previously approved these changes Jun 10, 2025
@Liam-qk Liam-qk force-pushed the fix_sta_twt_set_issue branch from 0d149be to 9638d11 Compare June 10, 2025 02:50
@github-actions github-actions bot requested a review from George-Stefan June 10, 2025 02:51
@MaochenWang1
Copy link
Contributor

Hi @jukkar @krish2718 please review

krish2718
krish2718 previously approved these changes Jun 10, 2025
@Liam-qk Liam-qk dismissed stale reviews from krish2718 and MaochenWang1 via 46d0158 June 18, 2025 06:06
@Liam-qk Liam-qk force-pushed the fix_sta_twt_set_issue branch from 9638d11 to 46d0158 Compare June 18, 2025 06:06
@Liam-qk
Copy link
Contributor Author

Liam-qk commented Jun 18, 2025

Update hal_nxp manifest to fix build errors.

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@Liam-qk
Copy link
Contributor Author

Liam-qk commented Jun 18, 2025

@krish2718 @MaochenWang1 @jukkar , please help review.

- hal
- name: hal_nxp
revision: 87233bcaabd2b65f8bc5f09325bbc52cf199c91e
revision: 33ec0a9eacfecf82b5a0a210498f751f389f8255
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Liam-qk please rebase your PR on TOT, and remove the west.yml change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

When try to set twt, system will try to
get interface status firstly.
In shim driver, miss filling twt_capable field.
The twt_capable is set as false by default.
Failed to set twt because of incorrect
twt_capable.

Add enhance code to fill twt_capable field
in shim driver.

Signed-off-by: Qiankun Li <qiankun.li@nxp.com>
@Liam-qk Liam-qk force-pushed the fix_sta_twt_set_issue branch from 846593f to 4bc7c02 Compare June 20, 2025 01:51
@Liam-qk Liam-qk requested a review from MaochenWang1 June 20, 2025 01:51
@sonarqubecloud
Copy link

@MaochenWang1
Copy link
Contributor

Hi @jukkar @krish2718 please review

@MaochenWang1
Copy link
Contributor

Hi @jukkar please review

@kartben kartben merged commit 702221d into zephyrproject-rtos:main Jun 26, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Wi-Fi Wi-Fi platform: NXP Drivers NXP Semiconductors, drivers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants