net: lib: zperf: fix compilation with UDP/TCP only #89988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
jukkar
reviewed
May 15, 2025
Member
jukkar
left a comment
jukkar
left a comment
There was a problem hiding this comment.
Could you also add a commit to this PR that adds similar change to UDP?
Fix regression introduced by zephyrproject-rtos#88747 that breaks linking with zperf server enabled but TCP or UDP disabled. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Contributor
Author
sure, done |
Damian-Nordic
changed the title
rlubos
approved these changes
May 15, 2025
jukkar
approved these changes
May 15, 2025
|
Contributor
|
Would this still resolve the issue if |
Contributor
Author
I'm not sure but I can see it's pretty common in Zephyr to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by #88747 that breaks linking with zperf server enabled but TCP or UDP disabled.