soc: silabs: siwx91x: add missing kconfig for ns16550 driver variant #90004
Conversation
| # Variant for the ns16550 driver | ||
| CONFIG_UART_NS16550_DW8250_DW_APB=y |
There was a problem hiding this comment.
Wouldn't Kconfig.defconfig be the right place? Putting it here means that you'll get conflicts/warnings if you want to make a build without any UART enabled (since the above option depends on UART_NS16550 being enabled?
| # Variant for the ns16550 driver | ||
| CONFIG_UART_NS16550_DW8250_DW_APB=y |
There was a problem hiding this comment.
Same here. IMO we should modify this with Kconfig.defconfig instead, i.e. something like:
configdefault UART_NS16550_DW8250_DW_APB
default y
The above should retain the dependency on UART_NS16550, making it still possible to completely disable UART support for a build.
There was a problem hiding this comment.
I have hesitate between those two options but only with config and not configdefault (always forgot it exists). With configdefault and inheritance of the dependancy, that's clearly the right things to do. Changed.
The ns16550 UART driver has multiple variant Kconfig options. To successfully run the uart_basic_api test, the correct variant must be selected. This commit adds the missing Kconfig option. Signed-off-by: Martin Hoff <martin.hoff@silabs.com>
Add missing uart tag for siwx91x boards. Signed-off-by: Martin Hoff <martin.hoff@silabs.com>
Martinhoff-maker
dismissed stale reviews from asmellby and jerome-pouiller
via
da46758
Martinhoff-maker
force-pushed
the
fix_usart_kconfig_siwx91x
branch
from
577ccdf to
da46758
Compare
|
v2: move to Kconfig.defconfig |
Martinhoff-maker
changed the title
|
5 participants
The ns16550 UART driver has multiple variant Kconfig options.
To successfully run the uart_basic_api test, the correct variant must be selected.
This commit adds the missing Kconfig options to the siwx917_rb4338a and siwx917_rb4342a boards.
I don't find the fix really clean but the proper way would be to have a different compatible.