ci: pr_metadata_check: convert DNM logic to python #90046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
force-pushed
the
pr-metadata-py
branch
from
177828c to
d3aab99
Compare
fabiobaltieri
added
DNM (manifest)
jhedberg
previously approved these changes
May 16, 2025
pdgendt
reviewed
May 16, 2025
fabiobaltieri
force-pushed
the
pr-metadata-py
branch
2 times, most recently
from
bbcd299 to
3cbaf86
Compare
pdgendt
previously approved these changes
May 17, 2025
nashif
reviewed
May 17, 2025
GitHub seems to have issue with workflow state caching that causes the DNM step to not work properly in few cases and not detecting changes in the DNM tag, forcing people to mess with tags or close/opening PRs, which in turns restarts all workflows. Convert the script to Python so that the tag data is guaranteed to be fresh. Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
fabiobaltieri
force-pushed
the
pr-metadata-py
branch
from
3cbaf86 to
10973ee
Compare
pdgendt
approved these changes
May 17, 2025
This comment was marked as resolved.
This comment was marked as resolved.
nashif
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, GH backends are causing more mysery recently, trying to work around it, proposing to keep this simple for a start see if helps, followups:
Yes I know this will use a shocking ONE github API call per PR, I'd say it's worth for not having to manually chase down PRs dropped from the merge list and close/reopen them or mess about with labels.
GitHub seems to have issue with workflow state caching that causes the DNM step to not work properly in few cases and not detecting changes in the DNM tag, forcing people to mess with tags or close/opening PRs, which in turns restarts all workflows.
Convert the script to Python so that the tag data is guaranteed to be fresh.