Bluetooth: Host: L2CAP: Fix checking signaling packets size #90058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Bluetooth
area: Bluetooth Host
github-actions
bot
requested review from
Thalley,
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
rugeGerritsen and
theob-pro
jhedberg
previously approved these changes
May 16, 2025
jhedberg
added
the
area: Bluetooth Qualification
Thalley
reviewed
May 16, 2025
Recent test specification added additional test for validating invalid packet sizes on L2CAP signaling channel. IUT is allowed to either disconnect link, ignore packet, reject packet or issue a warning to upper tester if other action is taken. To keep things in line with previous check for too small size simply ignore fixed size packets of invalid length. This was affecting L2CAP/COS/CED/BI-11-C qualification test. Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
cvinayak
approved these changes
May 16, 2025
|
Thalley
approved these changes
May 16, 2025
Contributor
Author
|
#AutoPTS run zephyr L2CAP |
|
Scheduled PR #90058 (comment), board: nrf52, estimated start time: 15:40:11, test case count: 97, estimated duration: 0:41:19 Test cases to be runL2CAP/COS/CED/BI-05-CL2CAP/COS/CED/BI-09-C L2CAP/COS/CED/BI-11-C L2CAP/COS/CED/BI-13-C L2CAP/COS/CED/BI-16-C L2CAP/COS/CED/BI-17-C L2CAP/COS/CFC/BV-01-C L2CAP/COS/CFC/BV-02-C L2CAP/COS/CFC/BV-03-C L2CAP/COS/CFC/BV-04-C L2CAP/COS/CFC/BV-05-C L2CAP/COS/ECFC/BV-01-C L2CAP/COS/ECFC/BV-02-C L2CAP/COS/ECFC/BV-03-C L2CAP/COS/ECFC/BV-04-C L2CAP/LE/CPU/BV-01-C L2CAP/LE/CPU/BV-02-C L2CAP/LE/CPU/BI-01-C L2CAP/LE/CPU/BI-02-C L2CAP/LE/REJ/BI-02-C L2CAP/LE/CFC/BV-01-C L2CAP/LE/CFC/BV-02-C L2CAP/LE/CFC/BV-03-C L2CAP/LE/CFC/BV-04-C L2CAP/LE/CFC/BV-05-C L2CAP/LE/CFC/BV-06-C L2CAP/LE/CFC/BV-07-C L2CAP/LE/CFC/BI-01-C L2CAP/LE/CFC/BV-08-C L2CAP/LE/CFC/BV-09-C L2CAP/LE/CFC/BV-10-C L2CAP/LE/CFC/BV-11-C L2CAP/LE/CFC/BV-12-C L2CAP/LE/CFC/BV-13-C L2CAP/LE/CFC/BV-14-C L2CAP/LE/CFC/BV-15-C L2CAP/LE/CFC/BV-16-C L2CAP/LE/CFC/BV-18-C L2CAP/LE/CFC/BV-19-C L2CAP/LE/CFC/BV-20-C L2CAP/LE/CFC/BV-21-C L2CAP/LE/CFC/BV-22-C L2CAP/LE/CFC/BV-23-C L2CAP/LE/CFC/BV-24-C L2CAP/LE/CFC/BV-25-C L2CAP/LE/CFC/BV-26-C L2CAP/LE/CFC/BV-27-C L2CAP/LE/CFC/BV-28-C L2CAP/LE/CFC/BV-29-C L2CAP/LE/CFC/BV-30-C L2CAP/LE/CFC/BV-31-C L2CAP/LE/CID/BI-01-C L2CAP/ECFC/BV-01-C L2CAP/ECFC/BV-02-C L2CAP/ECFC/BV-03-C L2CAP/ECFC/BV-04-C L2CAP/ECFC/BV-06-C L2CAP/ECFC/BV-07-C L2CAP/ECFC/BI-01-C L2CAP/ECFC/BI-02-C L2CAP/ECFC/BV-08-C L2CAP/ECFC/BV-09-C L2CAP/ECFC/BV-10-C L2CAP/ECFC/BV-11-C L2CAP/ECFC/BV-12-C L2CAP/ECFC/BV-13-C L2CAP/ECFC/BV-14-C L2CAP/ECFC/BV-15-C L2CAP/ECFC/BV-16-C L2CAP/ECFC/BV-17-C L2CAP/ECFC/BV-18-C L2CAP/ECFC/BV-19-C L2CAP/ECFC/BV-20-C L2CAP/ECFC/BV-21-C L2CAP/ECFC/BV-22-C L2CAP/ECFC/BV-23-C L2CAP/ECFC/BI-03-C L2CAP/ECFC/BV-24-C L2CAP/ECFC/BV-25-C L2CAP/ECFC/BI-04-C L2CAP/ECFC/BV-26-C L2CAP/ECFC/BV-27-C L2CAP/ECFC/BV-28-C L2CAP/ECFC/BV-29-C L2CAP/ECFC/BV-30-C L2CAP/ECFC/BV-31-C L2CAP/ECFC/BV-32-C L2CAP/ECFC/BV-33-C L2CAP/ECFC/BV-34-C L2CAP/ECFC/BV-35-C L2CAP/ECFC/BV-38-C L2CAP/ECFC/BV-39-C L2CAP/ECFC/BV-41-C L2CAP/ECFC/BI-05-C L2CAP/ECFC/BI-06-C L2CAP/ECFC/BI-07-C L2CAP/TIM/BV-03-C |
|
AutoPTS Bot results: Successful tests (97)L2CAP L2CAP/COS/CED/BI-05-C PASSL2CAP L2CAP/COS/CED/BI-09-C PASS L2CAP L2CAP/COS/CED/BI-11-C PASS L2CAP L2CAP/COS/CED/BI-13-C PASS L2CAP L2CAP/COS/CED/BI-16-C PASS L2CAP L2CAP/COS/CED/BI-17-C PASS L2CAP L2CAP/COS/CFC/BV-01-C PASS L2CAP L2CAP/COS/CFC/BV-02-C PASS L2CAP L2CAP/COS/CFC/BV-03-C PASS L2CAP L2CAP/COS/CFC/BV-04-C PASS L2CAP L2CAP/COS/CFC/BV-05-C PASS L2CAP L2CAP/COS/ECFC/BV-01-C PASS L2CAP L2CAP/COS/ECFC/BV-02-C PASS L2CAP L2CAP/COS/ECFC/BV-03-C PASS L2CAP L2CAP/COS/ECFC/BV-04-C PASS L2CAP L2CAP/ECFC/BI-01-C PASS L2CAP L2CAP/ECFC/BI-02-C PASS L2CAP L2CAP/ECFC/BI-03-C PASS L2CAP L2CAP/ECFC/BI-04-C PASS L2CAP L2CAP/ECFC/BI-05-C PASS L2CAP L2CAP/ECFC/BI-06-C PASS L2CAP L2CAP/ECFC/BI-07-C PASS L2CAP L2CAP/ECFC/BV-01-C PASS L2CAP L2CAP/ECFC/BV-02-C PASS L2CAP L2CAP/ECFC/BV-03-C PASS L2CAP L2CAP/ECFC/BV-04-C PASS L2CAP L2CAP/ECFC/BV-06-C PASS L2CAP L2CAP/ECFC/BV-07-C PASS L2CAP L2CAP/ECFC/BV-08-C PASS L2CAP L2CAP/ECFC/BV-09-C PASS L2CAP L2CAP/ECFC/BV-10-C PASS L2CAP L2CAP/ECFC/BV-11-C PASS L2CAP L2CAP/ECFC/BV-12-C PASS L2CAP L2CAP/ECFC/BV-13-C PASS L2CAP L2CAP/ECFC/BV-14-C PASS L2CAP L2CAP/ECFC/BV-15-C PASS L2CAP L2CAP/ECFC/BV-16-C PASS L2CAP L2CAP/ECFC/BV-17-C PASS L2CAP L2CAP/ECFC/BV-18-C PASS L2CAP L2CAP/ECFC/BV-19-C PASS L2CAP L2CAP/ECFC/BV-20-C PASS L2CAP L2CAP/ECFC/BV-21-C PASS L2CAP L2CAP/ECFC/BV-22-C PASS L2CAP L2CAP/ECFC/BV-23-C PASS L2CAP L2CAP/ECFC/BV-24-C PASS L2CAP L2CAP/ECFC/BV-25-C PASS L2CAP L2CAP/ECFC/BV-26-C PASS L2CAP L2CAP/ECFC/BV-27-C PASS L2CAP L2CAP/ECFC/BV-28-C PASS L2CAP L2CAP/ECFC/BV-29-C PASS L2CAP L2CAP/ECFC/BV-30-C PASS L2CAP L2CAP/ECFC/BV-31-C PASS L2CAP L2CAP/ECFC/BV-32-C PASS L2CAP L2CAP/ECFC/BV-33-C PASS L2CAP L2CAP/ECFC/BV-34-C PASS L2CAP L2CAP/ECFC/BV-35-C PASS L2CAP L2CAP/ECFC/BV-38-C PASS L2CAP L2CAP/ECFC/BV-39-C PASS L2CAP L2CAP/ECFC/BV-41-C PASS L2CAP L2CAP/LE/CFC/BI-01-C PASS L2CAP L2CAP/LE/CFC/BV-01-C PASS L2CAP L2CAP/LE/CFC/BV-02-C PASS L2CAP L2CAP/LE/CFC/BV-03-C PASS L2CAP L2CAP/LE/CFC/BV-04-C PASS L2CAP L2CAP/LE/CFC/BV-05-C PASS L2CAP L2CAP/LE/CFC/BV-06-C PASS L2CAP L2CAP/LE/CFC/BV-07-C PASS L2CAP L2CAP/LE/CFC/BV-08-C PASS L2CAP L2CAP/LE/CFC/BV-09-C PASS L2CAP L2CAP/LE/CFC/BV-10-C PASS L2CAP L2CAP/LE/CFC/BV-11-C PASS L2CAP L2CAP/LE/CFC/BV-12-C PASS L2CAP L2CAP/LE/CFC/BV-13-C PASS L2CAP L2CAP/LE/CFC/BV-14-C PASS L2CAP L2CAP/LE/CFC/BV-15-C PASS L2CAP L2CAP/LE/CFC/BV-16-C PASS L2CAP L2CAP/LE/CFC/BV-18-C PASS L2CAP L2CAP/LE/CFC/BV-19-C PASS L2CAP L2CAP/LE/CFC/BV-20-C PASS L2CAP L2CAP/LE/CFC/BV-21-C PASS L2CAP L2CAP/LE/CFC/BV-22-C PASS L2CAP L2CAP/LE/CFC/BV-23-C PASS L2CAP L2CAP/LE/CFC/BV-24-C PASS L2CAP L2CAP/LE/CFC/BV-25-C PASS L2CAP L2CAP/LE/CFC/BV-26-C PASS L2CAP L2CAP/LE/CFC/BV-27-C PASS L2CAP L2CAP/LE/CFC/BV-28-C PASS L2CAP L2CAP/LE/CFC/BV-29-C PASS L2CAP L2CAP/LE/CFC/BV-30-C PASS L2CAP L2CAP/LE/CFC/BV-31-C PASS L2CAP L2CAP/LE/CID/BI-01-C PASS L2CAP L2CAP/LE/CPU/BI-01-C PASS L2CAP L2CAP/LE/CPU/BI-02-C PASS L2CAP L2CAP/LE/CPU/BV-01-C PASS L2CAP L2CAP/LE/CPU/BV-02-C PASS L2CAP L2CAP/LE/REJ/BI-02-C PASS L2CAP L2CAP/TIM/BV-03-C PASS |
alwa-nordic
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent test specification added additional test for validating invalid packet sizes on L2CAP signaling channel. IUT is allowed to either disconnect link, ignore packet, reject packet or issue a warning to upper tester if other action is taken.
To keep things in line with previous check for too small size simply ignore fixed size packets of invalid length.
This was affecting L2CAP/COS/CED/BI-11-C qualification test.