Skip to content

Conversation

@jilaypandya
Copy link
Member

@jilaypandya jilaypandya commented May 17, 2025

  • Rename gpio stepper to h bridge stepper
  • Add a shield
  • Reduce the review scope of PR 91979 (The Stepper Split).

@jilaypandya jilaypandya force-pushed the boards/add-bridge-4-click branch 10 times, most recently from 01097cf to 306e372 Compare May 17, 2025 12:19
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@jilaypandya jilaypandya force-pushed the boards/add-bridge-4-click branch from 306e372 to 111a4f1 Compare July 7, 2025 15:35
@jilaypandya jilaypandya force-pushed the boards/add-bridge-4-click branch 2 times, most recently from 0a3e8b8 to 026a5bf Compare July 7, 2025 15:46
@jilaypandya jilaypandya marked this pull request as ready for review July 7, 2025 15:47
@github-actions github-actions bot requested review from kartben, nashif and rruuaanng July 7, 2025 15:48
@jilaypandya jilaypandya force-pushed the boards/add-bridge-4-click branch 2 times, most recently from 465ff49 to 413f52a Compare July 7, 2025 16:25
@jilaypandya jilaypandya force-pushed the boards/add-bridge-4-click branch 2 times, most recently from 8f55954 to 7a9cf72 Compare July 7, 2025 16:54
@jilaypandya jilaypandya requested a review from dipakgmx July 7, 2025 16:56
@jilaypandya jilaypandya force-pushed the boards/add-bridge-4-click branch from 7a9cf72 to 3f4b6be Compare July 7, 2025 17:01
@jilaypandya jilaypandya added this to the v4.3.0 milestone Jul 7, 2025
rename gpio stepper to h bridge stepper
minor correction in stepper_stop, stepper_stop shall cancel all active
movements and should not be concerned about keeping the coils energized
or not, since that is a concern of a motion controller and not a stepper
driver.

Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
add mikroe h bridge 4 click board to shields

Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
@jilaypandya jilaypandya force-pushed the boards/add-bridge-4-click branch from 3f4b6be to 32c78a7 Compare July 7, 2025 17:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

@kartben kartben assigned jilaypandya and unassigned kartben Jul 15, 2025
@aescolar aescolar merged commit 897590f into zephyrproject-rtos:main Jul 19, 2025
25 checks passed
@kartben
Copy link
Contributor

kartben commented Jul 19, 2025

@jilaypandya hey, at some point you guys will need to really start slowing down on the breaking changes, as this will start becoming a real issue for adoption 😶
Please add an entry to the migration guide for the rename.

@kartben
Copy link
Contributor

kartben commented Jul 19, 2025

Would have also been nice if the PR title would have allowed me to notice that I had a shield needing reviewing :/

@jilaypandya jilaypandya deleted the boards/add-bridge-4-click branch July 19, 2025 08:13
@jilaypandya
Copy link
Member Author

Would have also been nice if the PR title would have allowed me to notice that I had a shield needing reviewing :/

Sorry, my bad. The PR title should have definitely been more descriptive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants