actions: manifest: Handle binary blobs #90379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
fabiobaltieri,
kartben,
nashif and
stephanosio
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+56
to
+57
| blobs-added-labels: 'Binary Blobs Added' | ||
| blobs-modified-labels: 'Binary Blobs Modified' |
Member
There was a problem hiding this comment.
should one of these be a DNM one?
Member
Author
There was a problem hiding this comment.
The thing is that the action already sets "DNM (manifest)" whenever module.yml is modified anyway, so I don't think it's required.
carlescufi
force-pushed
the
manifest-action-update
branch
from
2b2899d to
8576bc6
Compare
carlescufi
added
DNM
Member
Author
|
Found an issue, DNM until it's fixed. |
Update to a revision of the manifest action that includes: zephyrproject-rtos/action-manifest#21 Also add the corresponding binary blobs labels parameters to the workflow. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
carlescufi
force-pushed
the
manifest-action-update
branch
from
8576bc6 to
1630e21
Compare
Member
Author
|
fabiobaltieri
approved these changes
May 23, 2025
|
nashif
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to a revision of the manifest action that includes: zephyrproject-rtos/action-manifest#21
Also add the corresponding binary blobs labels parameters to the workflow.