tests: Bluetooth: Audio: Add common TEST_SAMPLE_SIRK #90436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a common definition of the TEST_SAMPLE_SIRK used by the BSIM tests. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
|
github-actions
bot
requested review from
Casper-Bonde-Bose,
MariuszSkamra,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot,
pin-zephyr and
sjanc
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the test sample SIRK used in multiple Bluetooth Audio tests by replacing hardcoded byte arrays with a single common definition.
- Replace raw SIRK arrays with TEST_SAMPLE_SIRK constant
- Add common.h definition for TEST_SAMPLE_SIRK using REVERSE_ARGS for endianness handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/bsim/bluetooth/audio/src/gmap_ugt_test.c | Replaced hardcoded SIRK byte array with TEST_SAMPLE_SIRK |
| tests/bsim/bluetooth/audio/src/csip_set_member_test.c | Replaced hardcoded SIRK byte array with TEST_SAMPLE_SIRK |
| tests/bsim/bluetooth/audio/src/common.h | Added common definition for TEST_SAMPLE_SIRK |
| tests/bsim/bluetooth/audio/src/cap_acceptor_test.c | Replaced hardcoded SIRK byte array with TEST_SAMPLE_SIRK |
Comments suppressed due to low confidence (1)
tests/bsim/bluetooth/audio/src/common.h:75
- Clarify the comment to explicitly state that TEST_SAMPLE_SIRK is defined in big-endian order and reversed for use in little-endian environments, ensuring that the behavior of REVERSE_ARGS is well-documented and clear.
/* The sample SIRK as defined by the CSIS spec Appendix A.1. ...
babrsn
approved these changes
May 27, 2025
kartben
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a common definition of the TEST_SAMPLE_SIRK used by the BSIM tests.