Bluetooth: BAP: Use IN_RANGE in bt_bap_base_get_base_from_ad

[Thalley]

This simplyfies the checks in the function a bit, and makes Sonarcloud happy.

[Copilot]

Pull Request Overview

This PR refactors range checks in bt_bap_base_get_base_from_ad to use the IN_RANGE macro for clearer bounds validation and to satisfy SonarCloud rules.

• Replaced manual == 0 || > max checks for subgroup_count, bis_count, and bis_index with IN_RANGE
• Simplified conditional logic for better readability

Comments suppressed due to low confidence (3)

subsys/bluetooth/audio/bap_base.c:151

• Consider adding unit tests for boundary values of subgroup_count (1 and BASE_SUBGROUP_MAX_COUNT) as well as out-of-range values to verify the new IN_RANGE check returns NULL when expected.

if (!IN_RANGE(subgroup_count, 1U, BASE_SUBGROUP_MAX_COUNT)) {

subsys/bluetooth/audio/bap_base.c:167

• Add tests to cover bis_count exactly at the lower and upper limits (1 and BT_ISO_MAX_GROUP_ISO_COUNT) and just outside those limits to ensure the IN_RANGE macro works correctly.

if (!IN_RANGE(bis_count, 1U, BT_ISO_MAX_GROUP_ISO_COUNT)) {

subsys/bluetooth/audio/bap_base.c:205

• Include unit tests for bis_index boundary values (1 and BT_ISO_BIS_INDEX_MAX) and out-of-range cases to confirm the behavior of the IN_RANGE macro.

if (!IN_RANGE(bis_index, 1U, BT_ISO_BIS_INDEX_MAX)) {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud