openthread: Add header for OpenThread module #90588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
canisLupus1313,
edmont,
jukkar,
maciejbaczmanski,
mariuszpos,
pdgendt,
rlubos and
ssharks
rlubos
reviewed
May 26, 2025
Contributor
rlubos
left a comment
rlubos
left a comment
There was a problem hiding this comment.
Please fix the compliance.
Contributor
Author
|
@rlubos Fixed compliance and documentation build. |
rlubos
previously approved these changes
May 26, 2025
ArekBalysNordic
approved these changes
May 27, 2025
* Add header with public API of OpenThread module. * Add module include directory to Zephyr include directories. * Use new header in platform implementation. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Use OpenThread module header instead of redefining its API. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Add openthread module header to INPUT due to dependencies to symbols in `zephyr/net/openthread.h` Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Contributor
Author
|
@rlubos @ArekBalysNordic I replaced usage of old API in |
|
rlubos
approved these changes
May 28, 2025
LuDuda
approved these changes
May 30, 2025
jukkar
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #89090, the OpenThread implementation was moved from
netto themodule, but no public API header was added. As a result, it was not possible to use the implementation without includingzephyr/net/openthread.h.This PR adds a public API header to the OpenThread module and removes the corresponding declarations from
zephyr/net/openthread.hin favor of including the new module header.