Skip to content

drivers: sensor: icp101xx: remove logically dead code #90730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kartben merged 1 commit into from
May 28, 2025
Merged

drivers: sensor: icp101xx: remove logically dead code #90730

kartben merged 1 commit into from
May 28, 2025
+0 −4

Conversation

@kartben
Copy link
Contributor

@kartben kartben commented May 28, 2025 •
edited
Loading

Removed a logically dead else by doing sensor channel check
in a way that's more aligned with how other drivers do it.

Fixes: CID 505949
Fixes: #90558

@kartben kartben added Coverity A Coverity detected issue or its fix Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels May 28, 2025
@github-actions github-actions bot added the area: Sensors Sensors label May 28, 2025
@kartben
drivers: sensor: icp101xx: update channel check condition
ae3ac8a 
Removed a logically dead else by doing sensor channel check
in a way that's more aligned with how other drivers do it.

Fixes: CID 505949
Fixes: zephyrproject-rtos#90558
Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nashif
Copy link
Member

nashif commented May 28, 2025

dead else

?

@kartben
Copy link
Contributor Author

kartben commented May 28, 2025

dead else

?

Had updated the commit message but not the PR message, sorry.
The last "else" was (rightfully) being flagged as being dead by coverity. I had initially removed it, but then Sonaqloud complained I had no default else 😄 so ended up going for the approach that most sensor drivers seem to follow.

@kartben kartben merged commit fdf713a into zephyrproject-rtos:main May 28, 2025
29 checks passed
@kartben kartben deleted the CID505949 branch October 22, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teburd teburd teburd approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@ubieda ubieda ubieda approved these changes

@rbuisson-invn rbuisson-invn rbuisson-invn approved these changes

@afontaine-invn afontaine-invn Awaiting requested review from afontaine-invn

@asemjonovs asemjonovs Awaiting requested review from asemjonovs

@avisconti avisconti Awaiting requested review from avisconti

@gjabouley-invn gjabouley-invn Awaiting requested review from gjabouley-invn

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@sriccardi-invn sriccardi-invn Awaiting requested review from sriccardi-invn

@tristan-google tristan-google Awaiting requested review from tristan-google

@yperess yperess Awaiting requested review from yperess

Assignees

@MaureenHelm MaureenHelm

Labels

area: Sensors Sensors Coverity A Coverity detected issue or its fix Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Coverity CID: 505949] Logically dead code in drivers/sensor/tdk/icp101xx/icp101xx_drv.c

6 participants

@kartben @nashif @teburd @MaureenHelm @ubieda @rbuisson-invn