logging: fix bug where links wouldn't be promptly activated #90826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log process thread is what activates multidomain log links, but if all backends were already initialized, it would enter a mode where it would block until new local logs were ready to be processed, even if links were not yet completed in activation. Change the logic for computing the timeout used to block the processing thread so that it stays in periodic polling mode if there are still log links that haven't finished activating. Signed-off-by: Mike J. Chen <mjchen@google.com>
mjchen0
force-pushed
the
log_core_activitation_polling
branch
from
16f5880 to
57d62ed
Compare
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log process thread is what activates multidomain log links, but if all backends were already initialized, it would enter a mode where it would block until new local logs were ready to be processed, even if links were not yet completed in activation. Change the logic for computing the timeout used to block the processing thread so that it stays in periodic polling mode if there are still log links that haven't finished activating.