Skip to content

Conversation

@swamidas1998
Copy link

Increasing the mutex counts and event flag in order to avoid mutex failures in netoffload mode

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

Hello @swamidas1998, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

jerome-pouiller
jerome-pouiller previously approved these changes Jun 5, 2025
config CMSIS_V2_THREAD_MAX_STACK_SIZE
default 2048

config CMSIS_V2_MUTEX_MAX_COUNT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should use configdefault instead of config to override the default value of the existing symbol instead of shadowing it with a new symbol. See https://docs.zephyrproject.org/latest/build/kconfig/extensions.html

@swamidas1998 swamidas1998 force-pushed the fix/mutex-count-net-offload branch 5 times, most recently from 6a60aff to 54333c2 Compare June 9, 2025 10:02
Increasing the mutex counts and event flag in order to
avoid mutex failures in netoffload mode

Signed-off-by: SwamiDas Nampalli <swami.das@silabs.com>
Socket state is not moved to connected in the
siwx91x_sock_accept, hence the subsequent socket
calls(recv(), send()) fails since socket state is
not updated.

Signed-off-by: SwamiDas Nampalli <swami.das@silabs.com>
@swamidas1998 swamidas1998 force-pushed the fix/mutex-count-net-offload branch 4 times, most recently from 54333c2 to cf948a5 Compare June 11, 2025 03:54
@sonarqubecloud
Copy link

Copy link
Contributor

@jerome-pouiller jerome-pouiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first commit, the prefix should be soc: silabs: siwx91x: . Otherwise LGFM.

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 11, 2025
@jerome-pouiller
Copy link
Contributor

@swamidas1998 is this patch still relevant?

@github-actions github-actions bot removed the Stale label Aug 13, 2025
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Oct 13, 2025
@jerome-pouiller
Copy link
Contributor

I believe this PR is relevant. I am going to take it over.

@github-actions github-actions bot removed the Stale label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants