Skip to content

drivers: led: fix LED_BRIGTHNESS_MAX typo #91245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

drivers: led: fix LED_BRIGTHNESS_MAX typo #91245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion drivers/led/ht16k33.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ static int ht16k33_led_set_brightness(const struct device *dev, uint32_t led,
uint8_t dim;
uint8_t cmd;

dim = (value * (HT16K33_DIMMING_LEVELS - 1)) / LED_BRIGTHNESS_MAX;
dim = (value * (HT16K33_DIMMING_LEVELS - 1)) / LED_BRIGHTNESS_MAX;
cmd = HT16K33_CMD_DIMMING_SET | dim;

if (i2c_write_dt(&config->i2c, &cmd, sizeof(cmd))) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/is31fl3194.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ static int is31fl3194_set_brightness(const struct device *dev, uint32_t led, uin
}

/* Rescale 0..100 to 0..255 */
value = value * 255 / LED_BRIGTHNESS_MAX;
value = value * 255 / LED_BRIGHTNESS_MAX;

ret = i2c_reg_write_byte_dt(&config->bus, led_channels[led], value);
if (ret == 0) {
Expand Down
4 changes: 2 additions & 2 deletions drivers/led/is31fl3216a.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ static int is31fl3216a_update_pwm(const struct i2c_dt_spec *i2c)

static uint8_t is31fl3216a_brightness_to_pwm(uint8_t brightness)
{
return (0xFFU * brightness) / LED_BRIGTHNESS_MAX;
return (0xFFU * brightness) / LED_BRIGHTNESS_MAX;
}

static int is31fl3216a_led_write_channels(const struct device *dev,
Expand All @@ -87,7 +87,7 @@ static int is31fl3216a_led_write_channels(const struct device *dev,
i2c_buffer[0] = IS31FL3216A_REG_PWM_LAST - start_channel -
(num_channels - 1);
for (i = 0; i < num_channels; i++) {
if (buf[num_channels - i - 1] > LED_BRIGTHNESS_MAX) {
if (buf[num_channels - i - 1] > LED_BRIGHTNESS_MAX) {
return -EINVAL;
}
i2c_buffer[i + 1] = is31fl3216a_brightness_to_pwm(
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/is31fl3733.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ static int is31fl3733_led_set_brightness(const struct device *dev, uint32_t led,
{
const struct is31fl3733_config *config = dev->config;
int ret;
uint8_t led_brightness = (uint8_t)(((uint32_t)value * 255) / LED_BRIGTHNESS_MAX);
uint8_t led_brightness = (uint8_t)(((uint32_t)value * 255) / LED_BRIGHTNESS_MAX);

if (led >= IS31FL3733_MAX_LED) {
return -EINVAL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/led_dac.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ static int led_dac_set_brightness(const struct device *dev, uint32_t led, uint8_
value = pct > 0 ? config->leds[led].dac_min_brightness +
(uint64_t)(config->leds[led].dac_max_brightness -
config->leds[led].dac_min_brightness) *
pct / LED_BRIGTHNESS_MAX
pct / LED_BRIGHTNESS_MAX
: 0;

return led_dac_set_raw(dev, led, value);
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/led_pwm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ static int led_pwm_set_brightness(const struct device *dev,
dt_led = &config->led[led];

return pwm_set_pulse_dt(&config->led[led],
(uint32_t) ((uint64_t) dt_led->period * value / LED_BRIGTHNESS_MAX));
(uint32_t) ((uint64_t) dt_led->period * value / LED_BRIGHTNESS_MAX));
}

static int led_pwm_init(const struct device *dev)
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/led_shell.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ static int cmd_set_brightness(const struct shell *sh,
argv[arg_idx_value]);
return -EINVAL;
}
if (value > LED_BRIGTHNESS_MAX) {
if (value > LED_BRIGHTNESS_MAX) {
shell_error(sh, "Invalid LED brightness value %lu (max 100)",
value);
return -EINVAL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/lp3943.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ static int lp3943_led_set_brightness(const struct device *dev, uint32_t led,
reg = LP3943_PWM1;
}

val = (value * 255U) / LED_BRIGTHNESS_MAX;
val = (value * 255U) / LED_BRIGHTNESS_MAX;
if (i2c_reg_write_byte_dt(&config->bus, reg, val)) {
LOG_ERR("LED write failed");
return -EIO;
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/lp50xx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ static int lp50xx_set_brightness(const struct device *dev,
}

buf[0] = LP50XX_LED0_BRIGHTNESS(config->num_modules) + led_info->index;
buf[1] = (value * 0xff) / LED_BRIGTHNESS_MAX;
buf[1] = (value * 0xff) / LED_BRIGHTNESS_MAX;

return i2c_write_dt(&config->bus, buf, sizeof(buf));
}
Expand Down
12 changes: 6 additions & 6 deletions drivers/led/lp5562.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ static int lp5562_program_set_brightness(const struct device *dev,
{
uint8_t val;

val = (brightness * 0xFF) / LED_BRIGTHNESS_MAX;
val = (brightness * 0xFF) / LED_BRIGHTNESS_MAX;

return lp5562_program_command(dev, engine, command_index,
LP5562_PROG_COMMAND_SET_PWM, val);
Expand Down Expand Up @@ -781,7 +781,7 @@ static int lp5562_led_blink(const struct device *dev, uint32_t led,
}

ret = lp5562_program_set_brightness(dev, engine, command_index,
LED_BRIGTHNESS_MAX);
LED_BRIGHTNESS_MAX);
if (ret) {
return ret;
}
Expand All @@ -792,7 +792,7 @@ static int lp5562_led_blink(const struct device *dev, uint32_t led,
}

ret = lp5562_program_set_brightness(dev, engine, ++command_index,
LED_BRIGTHNESS_MAX);
LED_BRIGHTNESS_MAX);
if (ret) {
return ret;
}
Expand Down Expand Up @@ -845,7 +845,7 @@ static int lp5562_led_set_brightness(const struct device *dev, uint32_t led,
}
}

val = (value * 0xFF) / LED_BRIGTHNESS_MAX;
val = (value * 0xFF) / LED_BRIGHTNESS_MAX;

ret = lp5562_get_pwm_reg(led, &reg);
if (ret) {
Expand All @@ -862,7 +862,7 @@ static int lp5562_led_set_brightness(const struct device *dev, uint32_t led,

static inline int lp5562_led_on(const struct device *dev, uint32_t led)
{
return lp5562_led_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
return lp5562_led_set_brightness(dev, led, LED_BRIGHTNESS_MAX);
}

static inline int lp5562_led_off(const struct device *dev, uint32_t led)
Expand All @@ -882,7 +882,7 @@ static inline int lp5562_led_off(const struct device *dev, uint32_t led)
}
}

return lp5562_led_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
return lp5562_led_set_brightness(dev, led, LED_BRIGHTNESS_MAX);
}

static int lp5562_led_update_current(const struct device *dev)
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/lp5569.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ static int lp5569_led_set_brightness(const struct device *dev, uint32_t led, uin
}

/* Map 0-100 % to 0-255 pwm register value */
val = brightness * 255 / LED_BRIGTHNESS_MAX;
val = brightness * 255 / LED_BRIGHTNESS_MAX;

ret = i2c_reg_write_byte_dt(&config->bus, LP5569_LED0_PWM + led, val);
if (ret < 0) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/ncp5623.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ static int ncp5623_set_brightness(const struct device *dev, uint32_t led, uint8_
}

/* Rescale 0..100 to 0..31 */
value = value * NCP5623_MAX_BRIGHTNESS / LED_BRIGTHNESS_MAX;
value = value * NCP5623_MAX_BRIGHTNESS / LED_BRIGHTNESS_MAX;

ret = i2c_reg_write_byte_dt(&config->bus, led_channels[led] | value, 0x70);

Expand Down
2 changes: 1 addition & 1 deletion drivers/led/pca9633.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ static int pca9633_led_set_brightness(const struct device *dev, uint32_t led,
uint8_t val;

/* Set the LED brightness value */
val = (value * 255U) / LED_BRIGTHNESS_MAX;
val = (value * 255U) / LED_BRIGHTNESS_MAX;
if (i2c_reg_write_byte_dt(&config->i2c,
PCA9633_PWM_BASE + led,
val)) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/tlc59108.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ static int tlc59108_led_set_brightness(const struct device *dev, uint32_t led,
}

/* Set the LED brightness value */
val = (value * 255U) / LED_BRIGTHNESS_MAX;
val = (value * 255U) / LED_BRIGHTNESS_MAX;
if (i2c_reg_write_byte_dt(&config->i2c, TLC59108_PWM_BASE + led, val)) {
LOG_ERR("LED 0x%x reg write failed", TLC59108_PWM_BASE + led);
return -EIO;
Expand Down
6 changes: 3 additions & 3 deletions include/zephyr/drivers/led.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ extern "C" {
/**
* @brief Maximum brightness level, range is 0 to 100.
*/
#define LED_BRIGTHNESS_MAX 100u
#define LED_BRIGHTNESS_MAX 100u

/**
* @brief LED information structure
Expand Down Expand Up @@ -213,7 +213,7 @@ static inline int z_impl_led_set_brightness(const struct device *dev,
}
}

if (value > LED_BRIGTHNESS_MAX) {
if (value > LED_BRIGHTNESS_MAX) {
return -EINVAL;
}

Expand Down Expand Up @@ -337,7 +337,7 @@ static inline int z_impl_led_on(const struct device *dev, uint32_t led)
}

if (api->on == NULL) {
return api->set_brightness(dev, led, LED_BRIGTHNESS_MAX);
return api->set_brightness(dev, led, LED_BRIGHTNESS_MAX);
}

return api->on(dev, led);
Expand Down
Loading