samples: net: socketpair: ensure integration platform is on allow list #91616
Conversation
cfriedt
added
the
Hotfix
There was a problem hiding this comment.
Pull Request Overview
This PR updates the allow list configuration for the sample.net.sockets.socketpair.s32k148_evb integration platform by explicitly including the qemu_x86 platform.
- Changed the platform_allow attribute from an inline value to a multi-line list to support multiple allowed platforms.
- Added qemu_x86 alongside the existing s32k148_evb/s32k148 entry.
github-actions
bot
added
area: Samples
github-actions
bot
requested review from
jukkar,
kartben,
nashif,
pdgendt,
rlubos and
ssharks
stephanosio
left a comment
stephanosio
left a comment
There was a problem hiding this comment.
Give that sample.net.sockets.socketpair.s32k148_evb is intended to be run only on s32k148_evb/s32k148, wouldn't it make more sense to move integration_platforms from common to under sample.net.sockets.socketpair?
To be honest, I think I would prefer to undo the change here that was done just for this one platform in 49091ff and I think the project is generally moving in that direction. E.g. using tier0 platforms for CI mostly. There are many unique board configurations that can be put in place for many different tests, there are many different shields. Do we really need to take any of them into account to verify that this code works in our CI? Not really. It's also incredibly easy for NXP to use |
| platform_allow: s32k148_evb/s32k148 | ||
| platform_allow: | ||
| - s32k148_evb/s32k148 | ||
| - qemu_x86 |
There was a problem hiding this comment.
that looks wrong. This is a specific scenaion for some board, should not have qemu_x86, which is already covered in the previous one. Just move the integration platforms like from common to the main scenario instead.
|
Just notcied @stephanosio comment above, same thing I am saying here.
yes, fully agree here, this is getting out of hand with per platform sections and configurations, in a freaking sample. This needs to stop. |
cfriedt
force-pushed
the
socketpair-s32k148-evb-hotfix
branch
from
54c9c96 to
f4ccf0a
Compare
Ensure that qemu_x86 (the integration platform) is on the allow list for `sample.net.sockets.socketpair.s32k148_evb`. ``` INFO: Error found: sample.net.sockets.socketpair.s32k148_evb on qemu_x86/atom (Not in testsuite platform allow list but is one of the integration platforms) ``` Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
cfriedt
force-pushed
the
socketpair-s32k148-evb-hotfix
branch
from
f4ccf0a to
d8b6807
Compare
|
6 participants
Ensure that qemu_x86 (the integration platform) is on the allow list for
sample.net.sockets.socketpair.s32k148_evb.https://github.com/zephyrproject-rtos/zephyr/actions/runs/15646760002/job/44085509728?pr=91121
The issue was introduced in 49091ff.