Skip to content

Various coding guideline fixes #91619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nashif merged 8 commits into from
Jun 18, 2025
Merged

Various coding guideline fixes #91619

nashif merged 8 commits into from
Jun 18, 2025

Conversation

@nashif
Copy link
Member

@nashif nashif commented Jun 14, 2025 •
edited
Loading

  • sca: eclair: add Xen deviations
  • arch: x86: multiboot: add a break in default switch case
  • x86: mmu: add missing break statement in flags_to_entry function
  • lib: os: cbprintf_complete: add missing break statement in extract_flags function
  • ztest: add missing break statement in ztest_test_pass function
  • arm_mpu_v7m: add missing break statement in default case of writable check
  • drivers: uart: make ISR function static to match existing declaration
  • kernel: kswap: removes unused arch_swap function declaration

@github-actions github-actions bot added area: Testsuite Testsuite area: Base OS Base OS Library (lib/os) area: Formatting Output area: UART Universal Asynchronous Receiver-Transmitter area: Architectures area: X86 x86 Architecture (32-bit) area: ARM ARM (32-bit) Architecture area: Kernel area: Build System labels Jun 14, 2025
@nashif nashif force-pushed the topic/cg/fixes_001 branch 3 times, most recently from dcdb5c4 to 69f6fa9 Compare June 15, 2025 12:11
nordicjm
nordicjm previously approved these changes Jun 16, 2025
View reviewed changes
edersondisouza
edersondisouza previously approved these changes Jun 16, 2025
View reviewed changes
andyross
andyross previously approved these changes Jun 17, 2025
View reviewed changes
wearyzen
wearyzen reviewed Jun 17, 2025
View reviewed changes
nashif added 8 commits June 17, 2025 09:53
@nashif
sca: eclair: add Xen deviations
76e5513 
Import some useful Xen deviations that apply to Zephyr as well.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
arch: x86: multiboot: add a break in default switch case
d23501b 
Add missing break in switch statement.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
x86: mmu: add missing break statement in flags_to_entry function
7ff3169 
Add missing break in switch statement.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
lib: os: cbprintf_complete: add missing break statement
5866837 
Add missing break in switch statement.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
ztest: add missing break statement in ztest_test_pass function
05f1c35 
Adds missing break in switch statement.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
arm_mpu_v7m: add missing break statement in default case of writable …
9b20ab1 
…check

add missing break statement in default case of writable check to satisfy
sca.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
drivers: uart: make ISR function static to match existing declaration
b548135 
Declaration of the same function should match and be static.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif
kernel: kswap: removes unused arch_swap function declaration
0d1b586 
Eliminates the external declaration of the `arch_swap` function.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif dismissed stale reviews from andyross, edersondisouza, and nordicjm via 0d1b586 June 17, 2025 13:56
@nashif nashif force-pushed the topic/cg/fixes_001 branch from 69f6fa9 to 0d1b586 Compare June 17, 2025 13:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nashif nashif merged commit 72a8393 into zephyrproject-rtos:main Jun 18, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceolin ceolin ceolin approved these changes

@edersondisouza edersondisouza edersondisouza approved these changes

@tejlmand tejlmand tejlmand approved these changes

@laurenmurphyx64 laurenmurphyx64 laurenmurphyx64 approved these changes

@wearyzen wearyzen wearyzen approved these changes

@andyross andyross andyross left review comments

@nordicjm nordicjm nordicjm left review comments

@57300 57300 Awaiting requested review from 57300

@carlocaione carlocaione Awaiting requested review from carlocaione

@dcpleung dcpleung Awaiting requested review from dcpleung

@galak galak Awaiting requested review from galak

@jeremybettis jeremybettis Awaiting requested review from jeremybettis

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@microbuilder microbuilder Awaiting requested review from microbuilder

@najumon1980 najumon1980 Awaiting requested review from najumon1980

Assignees

@edersondisouza edersondisouza

Labels

area: Architectures area: ARM ARM (32-bit) Architecture area: Base OS Base OS Library (lib/os) area: Build System area: Formatting Output area: Kernel area: Testsuite Testsuite area: UART Universal Asynchronous Receiver-Transmitter area: X86 x86 Architecture (32-bit)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nashif @andyross @ceolin @edersondisouza @tejlmand @laurenmurphyx64 @nordicjm @wearyzen