Skip to content

Conversation

@cfriedt
Copy link
Member

@cfriedt cfriedt commented Jun 14, 2025

Previously, code like the snippet below would not pass compliance checks. With this change, we add CONFIG_BOARD_UNIT_TESTING to the Kconfig allow list, so that it is not incorrectly reported as a compliance failure.

#if defined(CONFIG_BOARD_UNIT_TESTING)
/* unit-testing only */
#endif

@cfriedt cfriedt changed the title scrips: ci: check_compliance: allow CONFIG_BOARD_UNIT_TESTING scripts: ci: check_compliance: allow CONFIG_BOARD_UNIT_TESTING Jun 14, 2025
Previously, code like the snippet below would not pass compliance checks.
With this change, we add `CONFIG_BOARD_UNIT_TESTING` to the Kconfig allow
list, so that code like the snippet below is not incorrectly reported as
a compliance failure.

```
if defined(CONFIG_BOARD_UNIT_TESTING)
/* unit-testing only */
endif
```

Signed-off-by: Chris Friedt <cfriedt@tenstorrent.com>
@cfriedt cfriedt force-pushed the board-unit-testing-compliance branch from b539446 to 233a2e3 Compare June 14, 2025 23:33
@cfriedt cfriedt marked this pull request as ready for review June 14, 2025 23:33
@github-actions github-actions bot added area: Coding Guidelines Coding guidelines and style size: XS A PR changing only a single line of code labels Jun 14, 2025
@cfriedt cfriedt closed this Jun 14, 2025
@cfriedt
Copy link
Member Author

cfriedt commented Jun 14, 2025

This can probably be merged with #90096

@cfriedt cfriedt deleted the board-unit-testing-compliance branch June 14, 2025 23:34
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Coding Guidelines Coding guidelines and style area: Continuous Integration area: Scripts Scripts size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants