samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

cvinayak · 2025-08-10T05:33:39Z

Update broadcaster_multiple sample to start multiple advertising sets of type legacy and extended advertising.

How they appear on-air (BabbleSim import), for 4 advertising sets:

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-22T19:29:37Z

subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

+ * scanning instances can expire changing the ticks_current value while we are querying for
+ * aux_offset value.
+ */
+#define MAX_RETRY_TICKS_CURRENT_CHANGE ((CONFIG_BT_CTLR_ADV_AUX_SET) - 1U +  2U)


[nitpick] Extra space in the macro definition. There are two spaces between -1U and +, should be one for consistency.

Suggested change

#define MAX_RETRY_TICKS_CURRENT_CHANGE ((CONFIG_BT_CTLR_ADV_AUX_SET) - 1U + 2U)

#define MAX_RETRY_TICKS_CURRENT_CHANGE ((CONFIG_BT_CTLR_ADV_AUX_SET) - 1U + 2U)

Copilot · 2025-11-22T19:29:37Z

samples/bluetooth/broadcaster_multiple/overlay-bt_ll_sw_split.conf

@@ -0,0 +1,30 @@
+# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets


Typo in comment: "gives" should be "give" (subject-verb agreement with "Increased to 4").

Suggested change

# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets

# Increased to 4 give one each of legacy, 2M, 1M and Coded PHY advertising sets

subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

tests/bsim/bluetooth/host/adv/chain/src/main.c

Enable similar Controller Kconfig features between nRF52 and nRF5340 BabbleSIM LE Audio testing. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Tune the aux offset calculation overhead assertion to use EVENT_OVERHEAD_START_US; this is the correct maximum overhead causing ISR latency for start of a radio event that occurs thereafter. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Fix missing auxiliary chain pdu time reservation. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Update broadcaster_multiple sample to start multiple advertising sets of type legacy and extended advertising. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Move Zephyr Controller Kconfigs to overlay file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Move harness and tags to common section for observer and broadcaster_multiple samples. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Do not use the BT_ prefix for definitions not provided by the Bluetooth subsystem. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

sonarqubecloud · 2025-11-27T16:15:49Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull request overview

Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot · 2025-11-27T18:20:30Z

tests/bsim/bluetooth/host/adv/chain/src/main.c

+#define AD_DATA_NAME_SIZE     (sizeof(CONFIG_BT_DEVICE_NAME) - 1U + 2U)
+#define AD_DATA_MFG_DATA_SIZE (254U + 2U)


[nitpick] Inconsistent naming: The macro prefix has been changed from BT_AD_DATA_ to AD_DATA_, but this creates inconsistency with Zephyr Bluetooth naming conventions. Other similar macros in the codebase typically use the BT_ prefix for Bluetooth-related definitions. Consider keeping the BT_ prefix for consistency.

Copilot · 2025-11-27T18:20:30Z

subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

+/* Maximum retries when ticks_current can change, example, when 3 extended advertising sets
+ * configured, and 1 advertising set is calculating the aux_offset, 2 other advertising sets and 2
+ * scanning instances can expire changing the ticks_current value while we are querying for


The comment phrase "example, when 3 extended advertising sets configured" is missing articles. It should read "for example, when 3 extended advertising sets are configured" for grammatical correctness.

Suggested change

/* Maximum retries when ticks_current can change, example, when 3 extended advertising sets

* configured, and 1 advertising set is calculating the aux_offset, 2 other advertising sets and 2

* scanning instances can expire changing the ticks_current value while we are querying for

/* Maximum retries when ticks_current can change; for example, when 3 extended advertising sets are

* configured, and 1 advertising set is calculating the aux_offset, 2 other advertising sets and 2

* scanning instances can expire, changing the ticks_current value while we are querying for

Copilot · 2025-11-27T18:20:31Z

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_vendor.h

 #endif /* !CONFIG_BT_CTLR_PHY_CODED */
 #else /* !CONFIG_BT_OBSERVER */
-/* Active connection in peripheral role with legacy scanning on 1M.
+/* Simultaneous 3 extended advertising sets calculating aux offsets.


Inconsistent punctuation and grammar: The comment on line 36 reads "Simultaneous 3 extended advertising sets calculating aux offsets." This should be "Simultaneous 3 extended advertising sets, calculating aux offsets." (adding comma) or better yet "3 simultaneous extended advertising sets calculating aux offsets." for better readability.

Suggested change

/* Simultaneous 3 extended advertising sets calculating aux offsets.

/* 3 simultaneous extended advertising sets calculating aux offsets.

Copilot · 2025-11-27T18:20:31Z

samples/bluetooth/broadcaster_multiple/overlay-bt_ll_sw_split.conf

@@ -0,0 +1,30 @@
+# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets


The comment incorrectly states "Increased to 4" when the value is being set for the first time in this new file. This should say "Set to 4" or "Value of 4" to accurately describe the configuration.

Suggested change

# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets

# Set to 4 to give one each of legacy, 2M, 1M and Coded PHY advertising sets

Copilot · 2025-11-27T18:20:31Z

subsys/bluetooth/controller/ll_sw/ull_adv_aux.c

+	uint32_t ticks_to_start;
+	uint32_t ticks_elapsed;
+	uint32_t ticks_now;


Variable declarations should be placed at the beginning of the function block, not after executable statements. The variables ticks_to_start, ticks_elapsed, and ticks_now are declared at line 3339-3341, after the assertion comment on line 3338. These should be moved to the top of the function with the other variable declarations (lines 3200-3215) to follow C89/C90 coding standards typically used in embedded systems.

cvinayak · 2025-12-01T20:13:25Z

@jhedberg and @alwa-nordic do review when possible.

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch 9 times, most recently from 771caba to 7afe802 Compare August 11, 2025 04:29

cvinayak marked this pull request as ready for review August 11, 2025 05:10

zephyrbot added platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim area: Bluetooth Controller area: Samples Samples area: Bluetooth HCI Bluetooth HCI Driver area: Bluetooth Audio area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth labels Aug 11, 2025

github-project-automation bot moved this to In Review in Bluetooth LE Audio Aug 11, 2025

github-project-automation bot added this to Bluetooth LE Audio Aug 11, 2025

zephyrbot requested review from HaavardRei, alwa-nordic, asbjornsabo, fredrikdanebjer, hermabe, jhedberg, jthm-ot, kartben, larsgk, nashif and niym-ot August 11, 2025 05:11

cvinayak removed this from the v4.3.0 milestone Oct 17, 2025

cvinayak added this to the v4.4.0 milestone Oct 27, 2025

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch 2 times, most recently from 56d6b00 to 1209301 Compare October 28, 2025 12:29

cvinayak requested a review from Copilot November 22, 2025 19:25

Copilot started reviewing on behalf of cvinayak November 22, 2025 19:26 View session

Copilot finished reviewing on behalf of cvinayak November 22, 2025 19:29

Copilot AI reviewed Nov 22, 2025

View reviewed changes

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch 3 times, most recently from f617a43 to 08574e2 Compare November 23, 2025 09:04

Thalley reviewed Nov 26, 2025

View reviewed changes

subsys/bluetooth/controller/ll_sw/ull_adv_aux.c Outdated Show resolved Hide resolved

tests/bsim/bluetooth/host/adv/chain/src/main.c Show resolved Hide resolved

cvinayak added 3 commits November 27, 2025 11:46

tests: bsim: Bluetooth: Enable similar Controller Kconfig features

7b69343

Enable similar Controller Kconfig features between nRF52 and nRF5340 BabbleSIM LE Audio testing. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Bluetooth: Controller: Fix missing chain pdu time reservation

81da8e5

Fix missing auxiliary chain pdu time reservation. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch from 08574e2 to 6182459 Compare November 27, 2025 15:31

cvinayak added 4 commits November 27, 2025 16:44

samples: Bluetooth: Broadcast multiple legacy and extended advertising

b478595

Update broadcaster_multiple sample to start multiple advertising sets of type legacy and extended advertising. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

samples: Bluetooth: observer: Move Zephyr Controller Kconfigs

6085418

Move Zephyr Controller Kconfigs to overlay file. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

samples: Bluetooth: Move harness and tags to common section

5c73cd2

Move harness and tags to common section for observer and broadcaster_multiple samples. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

tests: bsim: Bluetooth: Do not use the BT_ prefix

ae67cdc

Do not use the BT_ prefix for definitions not provided by the Bluetooth subsystem. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

cvinayak force-pushed the github_broadcast_multiple_with_legacy branch from 6182459 to ae67cdc Compare November 27, 2025 15:49

cvinayak requested review from Thalley and Copilot November 27, 2025 18:15

Copilot started reviewing on behalf of cvinayak November 27, 2025 18:16 View session

Copilot finished reviewing on behalf of cvinayak November 27, 2025 18:19

Copilot AI reviewed Nov 27, 2025

View reviewed changes

Thalley approved these changes Nov 28, 2025

View reviewed changes

carlescufi approved these changes Dec 1, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

cvinayak commented Aug 10, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 22, 2025

Uh oh!

Copilot AI Nov 22, 2025

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 27, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 27, 2025

Uh oh!

Copilot AI Nov 27, 2025

Uh oh!

Copilot AI Nov 27, 2025

Uh oh!

Copilot AI Nov 27, 2025

Uh oh!

Copilot AI Nov 27, 2025

Uh oh!

cvinayak commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	#define MAX_RETRY_TICKS_CURRENT_CHANGE ((CONFIG_BT_CTLR_ADV_AUX_SET) - 1U + 2U)
	#define MAX_RETRY_TICKS_CURRENT_CHANGE ((CONFIG_BT_CTLR_ADV_AUX_SET) - 1U + 2U)

		@@ -0,0 +1,30 @@
		# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets

	# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets
	# Increased to 4 give one each of legacy, 2M, 1M and Coded PHY advertising sets

		#define AD_DATA_NAME_SIZE (sizeof(CONFIG_BT_DEVICE_NAME) - 1U + 2U)
		#define AD_DATA_MFG_DATA_SIZE (254U + 2U)

	/* Simultaneous 3 extended advertising sets calculating aux offsets.
	/* 3 simultaneous extended advertising sets calculating aux offsets.

	# Increased to 4 gives one each of legacy, 2M, 1M and Coded PHY advertising sets
	# Set to 4 to give one each of legacy, 2M, 1M and Coded PHY advertising sets

samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

Are you sure you want to change the base?

samples: Bluetooth: Broadcast multiple legacy and extended advertising #94304

Conversation

cvinayak commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Nov 27, 2025

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

cvinayak commented Aug 10, 2025 •

edited

Loading