Skip to content

drivers: spi: Introduce Basic BFLB SPI driver #94752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kartben merged 5 commits into from
Nov 27, 2025
Merged

drivers: spi: Introduce Basic BFLB SPI driver #94752

kartben merged 5 commits into from
Nov 27, 2025

Conversation

@VynDragon
Copy link
Contributor

@VynDragon VynDragon commented Aug 20, 2025 •
edited
Loading

Caveats:

  • no async
  • no DMA
    - does not support faster bl61x spi. It does now

@zephyrbot zephyrbot added area: SPI SPI bus platform: Bouffalo Lab area: RISCV RISCV Architecture (32-bit & 64-bit) labels Aug 20, 2025
@VynDragon VynDragon force-pushed the bflb_spi branch 2 times, most recently from 54d0508 to 13b54ff Compare August 20, 2025 17:15
@VynDragon VynDragon mentioned this pull request Aug 28, 2025
Merged
@github-actions
Copy link

github-actions bot commented Aug 28, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_bouffalolab zephyrproject-rtos/hal_bouffalolab@4d6677b zephyrproject-rtos/hal_bouffalolab@ebecd18 (main) zephyrproject-rtos/hal_bouffalolab@4d6677b8..ebecd183

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_bouffalolab DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Aug 28, 2025
@nandojve
Copy link
Member

nandojve commented Sep 6, 2025

Hi @VynDragon ,

This PR still incomplete. You need to add this on a board + sample + tests.
You need to reorder the commits to reflect the correct dependency order, like bellow:

  • add dts bindings (if necessary by SoC)
  • SoC dtsi
  • SoC code
  • driver bindings (sometimes it came here if SoC code do not require changes)
  • driver
  • board
  • samples
  • tests

@VynDragon
Copy link
Contributor Author

VynDragon commented Sep 6, 2025

I'll reopen / remake this later, it's indeed incomplete atm especially due to recent changes on top of the issues you mentioned.

@VynDragon VynDragon closed this Sep 6, 2025
@nandojve
Copy link
Member

nandojve commented Sep 6, 2025

I'll reopen / remake this later, it's indeed incomplete atm especially due to recent changes on top of the issues you mentioned.

No need to close it. You can always move to/from draft.

josuah
josuah previously approved these changes Nov 20, 2025
View reviewed changes
@VynDragon VynDragon requested a review from josuah November 26, 2025 15:10
@VynDragon
Copy link
Contributor Author

VynDragon commented Nov 26, 2025

rebase

@VynDragon VynDragon assigned VynDragon and unassigned tbursztyka Nov 26, 2025
@VynDragon
Copy link
Contributor Author

VynDragon commented Nov 26, 2025

reassigned to self due to missing assignee.

@VynDragon
Copy link
Contributor Author

VynDragon commented Nov 26, 2025

@teburd @decsny Would either of you have the time to take a look at this please? Maintainer doesn't responds
Note it has the same issue as the previously reviewed by Tom i2c in that this driver lacks the more advanced way of working, it is also very similar HW, and the changes that were asked on that driver have been applied to that one unless i missed stuffs.

josuah
josuah previously approved these changes Nov 26, 2025
View reviewed changes
@nandojve
Copy link
Member

nandojve commented Nov 26, 2025

Hi @VynDragon ,
I think you already can merge hal and update here the hash.

@nandojve nandojve added this to the v4.4.0 milestone Nov 26, 2025
@VynDragon
west.yml: Update hal_bouffalolab to latest
84a4611 
Updates hal version to have spi defines fixes.

Signed-off-by: Camille BAUD <mail@massdriver.space>
@VynDragon
drivers: clock_control: bflb: Add SPI elements
aa5bbea 
Add clock elements to enable using SPI

Signed-off-by: Camille BAUD <mail@massdriver.space>
@VynDragon
dts: bflb: Add spi nodes
c7b77c2 
Adds Node for SPI driver to bl61x and bl70x

Signed-off-by: Camille BAUD <mail@massdriver.space>
@VynDragon
drivers: spi: Introduce Basic BFLB SPI driver
c54a6b4 
Introduce spi driver with basic features

Signed-off-by: Camille BAUD <mail@massdriver.space>
@VynDragon
boards: bflb: Add SPI tests support to some boards
a5be894 
Adds SPI tests running

Signed-off-by: Camille BAUD <mail@massdriver.space>
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Nov 26, 2025
@VynDragon
Copy link
Contributor Author

VynDragon commented Nov 26, 2025

Hello, I did it.

@VynDragon VynDragon requested a review from josuah November 26, 2025 23:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 27, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@kartben kartben merged commit a92b122 into zephyrproject-rtos:main Nov 27, 2025
30 checks passed
@VynDragon VynDragon deleted the bflb_spi branch November 28, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandojve nandojve nandojve approved these changes

@josuah josuah josuah approved these changes

@carlocaione carlocaione Awaiting requested review from carlocaione

@decsny decsny Awaiting requested review from decsny

@edersondisouza edersondisouza Awaiting requested review from edersondisouza

@fkokosinski fkokosinski Awaiting requested review from fkokosinski

@katsuster katsuster Awaiting requested review from katsuster

@kgugala kgugala Awaiting requested review from kgugala

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

@mgielda mgielda Awaiting requested review from mgielda

@npitre npitre Awaiting requested review from npitre

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@teburd teburd Awaiting requested review from teburd

@tgorochowik tgorochowik Awaiting requested review from tgorochowik

Assignees

@VynDragon VynDragon

Labels

area: Boards/SoCs area: Clock Control area: Devicetree Bindings area: RISCV RISCV Architecture (32-bit & 64-bit) area: SPI SPI bus manifest manifest-hal_bouffalolab platform: Bouffalo Lab

Projects

None yet

Milestone

v4.4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@VynDragon @nandojve @josuah @kartben @tbursztyka @zephyrbot