Bluetooth: BAP: Ep check fixes #95605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
ep_check_fix
branch
4 times, most recently
from
b12a603 to
c9e4bbe
Compare
zephyrbot
requested review from
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot and
sjanc
There was a problem hiding this comment.
Pull Request Overview
This PR refactors endpoint check functions in the Bluetooth BAP subsystem to have more descriptive names and be more strict in their validation. The changes replace generic "is_" function names with more specific "has_ep" naming conventions and add a missing function for unicast server endpoint validation.
- Renamed endpoint check functions from
bt_bap_ep_is_*tobt_bap_*_has_eppattern for better clarity - Added missing
bt_bap_unicast_server_has_epfunction and correspondingbt_ascs_has_epimplementation - Made endpoint validation more strict by adding proper checks for invalid endpoints
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/bluetooth/audio/cap_initiator/uut/bap_unicast_client.c | Updated function name and return value in test stub |
| tests/bluetooth/audio/ascs/uut/bap_unicast_client.c | Updated function name in test stub |
| subsys/bluetooth/audio/bap_unicast_server.c | Added new bt_bap_unicast_server_has_ep function |
| subsys/bluetooth/audio/bap_unicast_client.c | Renamed function from bt_bap_ep_is_unicast_client to bt_bap_unicast_client_has_ep |
| subsys/bluetooth/audio/bap_stream.c | Updated function calls to use new naming convention and added strict endpoint validation |
| subsys/bluetooth/audio/bap_iso.c | Updated function calls to use new naming convention |
| subsys/bluetooth/audio/bap_internal.h | Added function declarations for the new endpoint check functions |
| subsys/bluetooth/audio/bap_endpoint.h | Removed old function declarations |
| subsys/bluetooth/audio/bap_broadcast_source.c | Renamed function and fixed array check macro |
| subsys/bluetooth/audio/bap_broadcast_sink.c | Renamed function and fixed array check macro |
| subsys/bluetooth/audio/ascs_internal.h | Added bt_ascs_has_ep function declaration |
| subsys/bluetooth/audio/ascs.c | Added implementation of bt_ascs_has_ep function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Thalley
force-pushed
the
ep_check_fix
branch
from
c9e4bbe to
d6594e8
Compare
Thalley
force-pushed
the
ep_check_fix
branch
from
d6594e8 to
988403a
Compare
larsgk
reviewed
Sep 23, 2025
subsys/bluetooth/audio/ascs.c
Outdated
| bool bt_ascs_has_ep(const struct bt_bap_ep *ep) | ||
| { | ||
| return PART_OF_ARRAY(ascs.ase_pool, ep); | ||
| } |
Contributor
There was a problem hiding this comment.
Duplicate of bool bt_ascs_is_ase_ep(const struct bt_bap_ep *ep) (line 1450)?
Contributor
Author
There was a problem hiding this comment.
Indeed it is - Thanks for spotting this
We check for all other roles when checking whether an endpoint can send or receive, except for the unicast server. It is technically implied, but if the ep is not a valid pointer, then we may access invalid memory. Add check for bt_bap_ep_is_unicast_server (which uses the new bt_ascs_has_ep function). Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Rename the bt_bap_is_x_ep functions to better match the modules where they are implemented. Additionally modify the check to use IS_ARRAY_ELEMENT in the broadcast sink and source for a stricter check. IS_ARRAY_ELEMENT cannot easily be used in the unicast client and server, as the endpoints are part of another structure. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
Thalley
force-pushed
the
ep_check_fix
branch
from
988403a to
8dbb366
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
fredrikdanebjer
approved these changes
Sep 29, 2025
larsgk
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the ep check functions to have better names and to be more strict, as well as adding a missing function.