Skip to content

Conversation

@kylebonnici
Copy link
Contributor

@kylebonnici kylebonnici commented Oct 23, 2025

Since the merging of:

Now that #92334 is merged, We should align remaining files as Some files were added without proper formatting, and new rules were introduced to the DTS linter.

This PR aligns all remaining files in the repository with the updated DTS linting and formatting rules.

Bump up dts-linter to 0.3.1 to fix issue when json output is not flushed to stdout
before dts-linter exits.

Bump up dts-linter to 0.3.2 to address undefined in annotation
messages

@kylebonnici
Copy link
Contributor Author

Linter Found was unable to format this file due to syntax error in the file.

zephyr/dts/arm/nxp/nxp_mcxe31x_common.dtsi#L679

Node name is missing.

	quadspi_ardb: @68000000 {
		compatible = "nxp,";
		reg = <0x68000000 0x21c>;
		status = "disabled";
	};

@JarmouniA
Copy link
Contributor

JarmouniA commented Oct 23, 2025

Linter Found was unable to format this file due to syntax error in the file.

zephyr/dts/arm/nxp/nxp_mcxe31x_common.dtsi#L679

Node name is missing.

	quadspi_ardb: @68000000 {
		compatible = "nxp,";
		reg = <0x68000000 0x21c>;
		status = "disabled";
	};

That file is filled with fake compatibles and meaningless node names I don't know how it was approved, looks generated by an LLM (the commit msg says "generate")

Update: was generated by a script #95560 (comment)

@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch from 47ff45b to ecf4b50 Compare October 23, 2025 23:50
@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch 3 times, most recently from 092e7fc to f43e49c Compare October 24, 2025 00:48
@kylebonnici
Copy link
Contributor Author

@aescolar
Copy link
Member

@kylebonnici this PR is changing so many files that part of the automation seems to have given up.

Do you need me to split commits for better review as I had done in

Either that, or somebody reviews the patch (probably locally) and dares bless it here

@aescolar
Copy link
Member

All spaces changes filtered out:

git pr 98158
git diff --ignore-space-at-eol -b -w --ignore-blank-lines HEAD^ | less

diff: https://gist.githubusercontent.com/aescolar/c673230e9b07d4c5809f5b54ac5e9096/raw/04975260fbc896e06e8b7568d2dad3f75b17f48b/gistfile1.txt

Includes changes to package-lock.json & package.json

CC @mbolivar @decsny @rruuaanng @kartben @nashif @nordicjm

@kylebonnici
Copy link
Contributor Author

All spaces changes filtered out:

git pr 98158
git diff --ignore-space-at-eol -b -w --ignore-blank-lines HEAD^ | less

diff: https://gist.githubusercontent.com/aescolar/c673230e9b07d4c5809f5b54ac5e9096/raw/04975260fbc896e06e8b7568d2dad3f75b17f48b/gistfile1.txt

Includes changes to package-lock.json & package.json

CC @mbolivar @decsny @rruuaanng @kartben @nashif @nordicjm

FYI linter is bumped up as requested in a separate PR

@kylebonnici
Copy link
Contributor Author

@kylebonnici this PR is changing so many files that part of the automation seems to have given up.

Do you need me to split commits for better review as I had done in

Either that, or somebody reviews the patch (probably locally) and dares bless it here

Will split commits and see if it helps

@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch from f43e49c to f784ed4 Compare October 24, 2025 13:13
Copy link
Contributor

@mbolivar mbolivar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, thanks for continuing to push on this!

One issue I'd like to see fixed, and one question.

@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch 4 times, most recently from 52eba34 to db155ac Compare October 27, 2025 20:17
@kylebonnici
Copy link
Contributor Author

@mbolivar am I right to assume this PR will be merged after the release?

mbolivar
mbolivar previously approved these changes Oct 29, 2025
@mbolivar mbolivar self-assigned this Oct 29, 2025
@mbolivar mbolivar added this to the v4.4.0 milestone Oct 29, 2025
@mbolivar
Copy link
Contributor

@mbolivar am I right to assume this PR will be merged after the release?

It definitely won't be merged for this release, but let's try to get it in early in the next cycle so you don't have to rebase this thing forever. Thanks again! LGTM now.

@mbolivar
Copy link
Contributor

@kylebonnici please take a look at the CI failures and fix htem

fabiobaltieri
fabiobaltieri previously approved these changes Nov 19, 2025
@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch from afddb46 to 56e48c5 Compare November 19, 2025 17:10
@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch from 56e48c5 to df16556 Compare November 20, 2025 15:03
fabiobaltieri
fabiobaltieri previously approved these changes Nov 27, 2025
Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'd suggest just doing a commit per root directory here, like one for boards/ and one for tests/, I see you like to live on the edge of the rebase limit but these commit bomb can be a bit of a pain to deal with downstream :-) anyway won't bother doing it now just if you need to do another push on top of this

rruuaanng
rruuaanng previously approved these changes Nov 27, 2025
Applying dts-linter results for format files in

boards

Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
@kylebonnici kylebonnici dismissed stale reviews from rruuaanng and fabiobaltieri via e485276 November 27, 2025 22:08
@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch from df16556 to e485276 Compare November 27, 2025 22:08
@kylebonnici
Copy link
Contributor Author

thanks, I'd suggest just doing a commit per root directory here, like one for boards/ and one for tests/, I see you like to live on the edge of the rebase limit but these commit bomb can be a bit of a pain to deal with downstream :-) anyway won't bother doing it now just if you need to do another push on top of this

@fabiobaltieri Rebased. Squashed per dir. Last commit is the only formatting needed after rebasing

Applying dts-linter results for files in

dts

Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results for format files in

samples

Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results for files in

tests

Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results for remaining format files

Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results files after rebase

Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
@kylebonnici kylebonnici force-pushed the formatting/dts-align-remaining-files branch from e485276 to 67b336b Compare November 27, 2025 22:26
@sonarqubecloud
Copy link

Copy link
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabiobaltieri
Copy link
Member

Looks like Marti previously approved it, merging so it does not get caught in an infinite rebase loop.

@fabiobaltieri fabiobaltieri merged commit 787bc17 into zephyrproject-rtos:main Nov 28, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants