-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Linting: Align DTS linting rules and formatting #98158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting: Align DTS linting rules and formatting #98158
Conversation
|
Linter Found was unable to format this file due to syntax error in the file.
Node name is missing. |
That file is filled with fake compatibles and meaningless node names I don't know how it was approved, looks generated by an LLM (the commit msg says "generate") Update: was generated by a script #95560 (comment) |
47ff45b to
ecf4b50
Compare
092e7fc to
f43e49c
Compare
|
Do you need me to split commits for better review as I had done in |
|
@kylebonnici this PR is changing so many files that part of the automation seems to have given up.
Either that, or somebody reviews the patch (probably locally) and dares bless it here |
|
All spaces changes filtered out: Includes changes to |
FYI linter is bumped up as requested in a separate PR |
Will split commits and see if it helps |
f43e49c to
f784ed4
Compare
mbolivar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, thanks for continuing to push on this!
One issue I'd like to see fixed, and one question.
...s/clock_control/stm32_clock_configuration/stm32_common_devices/boards/f4_sdmmc48_pll.overlay
Show resolved
Hide resolved
52eba34 to
db155ac
Compare
|
@mbolivar am I right to assume this PR will be merged after the release? |
It definitely won't be merged for this release, but let's try to get it in early in the next cycle so you don't have to rebase this thing forever. Thanks again! LGTM now. |
|
@kylebonnici please take a look at the CI failures and fix htem |
afddb46 to
56e48c5
Compare
56e48c5 to
df16556
Compare
fabiobaltieri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I'd suggest just doing a commit per root directory here, like one for boards/ and one for tests/, I see you like to live on the edge of the rebase limit but these commit bomb can be a bit of a pain to deal with downstream :-) anyway won't bother doing it now just if you need to do another push on top of this
Applying dts-linter results for format files in boards Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
e485276
df16556 to
e485276
Compare
@fabiobaltieri Rebased. Squashed per dir. Last commit is the only formatting needed after rebasing |
Applying dts-linter results for files in dts Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results for format files in samples Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results for files in tests Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results for remaining format files Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Applying dts-linter results files after rebase Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
e485276 to
67b336b
Compare
|
fabiobaltieri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
|
Looks like Marti previously approved it, merging so it does not get caught in an infinite rebase loop. |



Since the merging of:
Now that #92334 is merged, We should align remaining files as Some files were added without proper formatting, and new rules were introduced to the DTS linter.
This PR aligns all remaining files in the repository with the updated DTS linting and formatting rules.
Bump up dts-linter to 0.3.1 to fix issue when json output is not flushed to stdout
before dts-linter exits.
Bump up dts-linter to 0.3.2 to address
undefinedin annotationmessages