soc: silabs: siwg917: Add configurable NWP boot features via DTS and Kconfig #98655

ArunmaniAlagarsamy2710 · 2025-10-31T12:39:29Z

Adds support for configuring SiWx91x NWP boot features using Devicetree and Kconfig.
Introduces new DTS properties for hardware-specific options (e.g., RTC sync, 1.8 V support, XTAL correction, QSPI 80 MHz, front-end switch modes) and Kconfig entries for software-defined boot configurations.

jerome-pouiller

Nice improvements!

jerome-pouiller · 2025-11-03T11:56:19Z

dts/bindings/net/wireless/silabs,siwx91x-nwp.yaml

+    type: boolean
+    description: |
+      Disables automatic 40 MHz XTAL frequency correction.
+      Enable this for calibration applications, or when using a custom XTAL


Since you use a "negative" boolean (disable-), the word "Enable" is twisted (you mean enabling the disabling, that's it?).

Short, I suggest to avoid "Negative" boolean arithmetic.

jerome-pouiller · 2025-11-03T11:57:34Z

dts/bindings/net/wireless/silabs,siwx91x-nwp.yaml

+      Enables Real-Time Clock (RTC) synchronization from the host system.
+      When enabled, the NWP uses the host's RTC for timekeeping and certificate
+      validation timing.
+      Enable this when the host MCU provides a valid RTC source.


If this feature is not enabled, how the NWP retrieve time?

If disabled, NWP uses SNTP for timekeeping, but RTC is needed for certificate validation.

Note: Currently, Zephyr do not implement TLS offloading. NWP certificate validation is never used. So, I believe mentioning certificate validation is confusing.

BTW, what is the purpose of timekeeping outside of certificate validation?

dts/bindings/net/wireless/silabs,siwx91x-nwp.yaml

jerome-pouiller · 2025-11-03T12:11:47Z

dts/bindings/net/wireless/silabs,siwx91x-nwp.yaml

+      the external RF switch. Use this on boards with an external front-end
+      switch network.
+      This corresponds to BIT(29) – SL_SI91X_EXT_FEAT_FRONT_END_SWITCH_PINS_ULP_GPIO_4_5_0.
+      Mutually exclusive with 'front-end-internal-switch'.


Maybe you prefer an enum rather than two dependent boolean:

antenna-selection: type: string description: [...] enum: - "none" - "ext-gpios" - "internal"

If you sort properly the enum values, you could directly assign it to bits 29-30 (BTW, I don't get the difference between SL_SI91X_EXT_FEAT_FRONT_END_INTERNAL_SWITCH and no front-end at all).

The internal switch mode uses the SiWx917’s on-chip T/R switch logic, while “no front-end” means no RF switching is active.
Internal mode doesn’t use GPIOs and doesn’t support RF_BLE_TX (8 dBm).
Agreed, aligning enum values to bits [30:29] makes sense.

jerome-pouiller · 2025-11-03T12:13:27Z

drivers/wifi/siwx91x/Kconfig.siwx91x

+config WIFI_SILABS_SIWX91X_FEAT_HIDE_PSK_CREDENTIALS
+	bool "Hide PSK and Sensitive Credentials"
+	help
+	  Hides sensitive credentials such as PSK, PMK, and EAP.


You mean, in the logs?

drivers/wifi/siwx91x/Kconfig.siwx91x

jerome-pouiller · 2025-11-03T12:14:25Z

soc/silabs/silabs_siwx91x/siwg917/siwx91x_nwp.c

+{
+	uint32_t ext_feat = 0;
+
+#if DT_NODE_HAS_PROP(NWP_NODE, front_end_internal_switch)


I don't believe you need preprocessor macros. if (DT_NODE_HAS_PROP(NWP_NODE, front_end_internal_switch)) { ... } should work

Moreover, I think you should retrieve the configuration in the driver initialization and put it in the siwx91x_nwp_config struct like it was done for power-profile or stack-size in SIWX91X_NWP_DEFINE.
It adds an intermediate step but allows to not have DT macro inside of the code.

Martinhoff-maker

Good improvements ! Only have a question: Do you take care that if the Bluetooth is also activated (coex), it will not conflict ?

Martinhoff-maker · 2025-11-04T08:53:51Z

boards/silabs/radio_boards/siwx917_rb4338a/siwx917_rb4338a.dts

 };
+
+&nwp {
+	front-end-switch-gpios;


why do you need to set this properties here if it's already present in siwg917.dtsi ?

Martinhoff-maker · 2025-11-04T08:54:20Z

soc/silabs/silabs_siwx91x/siwg917/siwx91x_nwp.c

+{
+	uint32_t ext_feat = 0;
+
+#if DT_NODE_HAS_PROP(NWP_NODE, front_end_internal_switch)


Moreover, I think you should retrieve the configuration in the driver initialization and put it in the siwx91x_nwp_config struct like it was done for power-profile or stack-size in SIWX91X_NWP_DEFINE.
It adds an intermediate step but allows to not have DT macro inside of the code.

jerome-pouiller · 2025-11-04T12:53:40Z

dts/bindings/net/wireless/silabs,siwx91x-nwp.yaml

+      Enables Real-Time Clock (RTC) synchronization from the host system.
+      When enabled, the NWP uses the host's RTC for timekeeping and certificate
+      validation timing.
+      Enable this when the host MCU provides a valid RTC source.


Note: Currently, Zephyr do not implement TLS offloading. NWP certificate validation is never used. So, I believe mentioning certificate validation is confusing.

BTW, what is the purpose of timekeeping outside of certificate validation?

jerome-pouiller · 2025-11-04T13:04:41Z

dts/bindings/net/wireless/silabs,siwx91x-nwp.yaml

+      Enables 1.8 V operation support for the NWP power domain.
+      Enable this if the board powers the NWP with 1.8 V instead of 3.3 V.
+
+  disable-xtal-correction:


Rename in enable-xtal-correction and inverse the logic in the code.

I see. This logic allows to directly map the Wiseconnect flags... why not.

jerome-pouiller · 2025-11-04T13:07:45Z

soc/silabs/silabs_siwx91x/siwg917/siwx91x_nwp.c

 	void (*config_irq)(const struct device *dev);
 	uint32_t stack_size;
 	uint8_t power_profile;
+	const char *antenna_selection;


Use DT_INST_ENUM_IDX() to automatically convert the string into an int.

jerome-pouiller · 2025-11-04T13:17:02Z

soc/silabs/silabs_siwx91x/siwg917/siwx91x_nwp.c

+		.disable_xtal_correction = DT_PROP_OR(DT_DRV_INST(inst),                           \
+						      disable_xtal_correction, false),             \
+		.qspi_80mhz_clk = DT_PROP_OR(DT_DRV_INST(inst), qspi_80mhz_clk, false),            \
+		.antenna_selection = DT_PROP_OR(DT_DRV_INST(inst), antenna_selection, "none"),     \


You don't need DT_PROP_OR(). From api-usage.rst:

Use DT_PROP() [...] will expand to either 0 or 1 depending on if the property
is present or absent.

You can even use DT_INST_PROP() so you won't need DT_DRV_INST().

jerome-pouiller · 2025-11-04T13:19:50Z

soc/silabs/silabs_siwx91x/siwg917/siwx91x_nwp.c


+	if (IS_ENABLED(CONFIG_WIFI_SILABS_SIWX91X_FEAT_SECURITY_PSK)) {
+		boot_config->feature_bit_map |= SL_SI91X_FEAT_SECURITY_PSK;
+	}


For readability, does it make sense to set this bit if CONFIG_WIFI_SILABS_SIWX91X is not set? (BTW, maybe CONFIG_WIFI_SILABS_SIWX91X_ROAMING_USE_DEAUTH should also be relocated)

jerome-pouiller · 2025-11-04T13:26:10Z

soc/silabs/silabs_siwx91x/siwg917/siwx91x_nwp.c

+		}
+	}
+
+	if (cfg->antenna_selection) {


In fact, you can write:

#define SL_SI91X_EXT_FEAT_FRONT_END_MSK (BIT(30) | BIT(29)) [...] boot_config->ext_custom_feature_bit_map &= ~SL_SI91X_EXT_FEAT_FRONT_END_MASK; boot_config->ext_custom_feature_bit_map |= FIELD_PREP(SL_SI91X_EXT_FEAT_FRONT_END_MSK, cfg->antenna_selection); [...] .antenna_selection = DT_INST_ENUM_IDX(inst, antenna_selection),

jerome-pouiller · 2025-11-04T13:40:53Z

soc/silabs/silabs_siwx91x/siwg917/siwx91x_nwp.c

 	}
 }

+static void siwx91x_apply_nwp_config(const struct device *dev,


Everything in this file is related to nwp. Maybe we should rename this function in siwx91x_apply_hw_config()?

Add new Devicetree properties under the SiWx91x NWP node to describe hardware-specific boot configuration options. The properties are documented in the SiWx91x NWP YAML binding. Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>

Add support for configuring hardware-specific boot feature bitmaps through Devicetree and software-specific boot configurations through Kconfig options. Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>

sonarqubecloud · 2025-11-05T10:11:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ArunmaniAlagarsamy2710 force-pushed the fix/boot-configs branch 2 times, most recently from 3fbda12 to 4f1c22f Compare November 3, 2025 11:36

ArunmaniAlagarsamy2710 marked this pull request as ready for review November 3, 2025 11:36

zephyrbot added area: Boards/SoCs platform: Silabs Silicon Labs area: Devicetree Bindings area: Wi-Fi Wi-Fi labels Nov 3, 2025

zephyrbot requested review from Kludentwo, MaochenWang1, Martinhoff-maker, asmellby, jerome-pouiller, jhedberg, jukkar, krish2718 and rlubos November 3, 2025 11:38

zephyrbot assigned jhedberg and asmellby Nov 3, 2025

jerome-pouiller reviewed Nov 3, 2025

View reviewed changes

Martinhoff-maker reviewed Nov 4, 2025

View reviewed changes

ArunmaniAlagarsamy2710 force-pushed the fix/boot-configs branch from 4f1c22f to 3577970 Compare November 4, 2025 10:19

ArunmaniAlagarsamy2710 requested review from Martinhoff-maker and jerome-pouiller November 4, 2025 10:23

ArunmaniAlagarsamy2710 force-pushed the fix/boot-configs branch from 3577970 to c5815f0 Compare November 4, 2025 11:23

Martinhoff-maker mentioned this pull request Nov 4, 2025

silabs: siwg917: cleanup and add configurable 802.11w MFP support #98273

Closed

jerome-pouiller reviewed Nov 4, 2025

View reviewed changes

ArunmaniAlagarsamy2710 added 2 commits November 5, 2025 15:22

soc: silabs: siwg917: Add configurable boot features via DTS and Kconfig

294e0bb

Add support for configuring hardware-specific boot feature bitmaps through Devicetree and software-specific boot configurations through Kconfig options. Signed-off-by: Arunmani Alagarsamy <arunmani.a@silabs.com>

ArunmaniAlagarsamy2710 force-pushed the fix/boot-configs branch from c5815f0 to 294e0bb Compare November 5, 2025 09:54

ArunmaniAlagarsamy2710 requested a review from jerome-pouiller November 5, 2025 09:57

jerome-pouiller approved these changes Nov 5, 2025

View reviewed changes

jhedberg added this to the v4.4.0 milestone Nov 5, 2025

jerome-pouiller mentioned this pull request Nov 5, 2025

soc: silabs: siwg917: Remove SL_SI91X_EXT_FEAT_FRONT_END_INTERNAL_SWITCH #98365

Closed

Martinhoff-maker approved these changes Nov 5, 2025

View reviewed changes

jerome-pouiller mentioned this pull request Nov 5, 2025

soc: silabs: siwx91x: Improve performance #98060

Open

jhedberg approved these changes Nov 27, 2025

View reviewed changes

carlescufi merged commit 1814b90 into zephyrproject-rtos:main Nov 27, 2025
27 checks passed

soc: silabs: siwg917: Add configurable NWP boot features via DTS and Kconfig #98655

soc: silabs: siwg917: Add configurable NWP boot features via DTS and Kconfig #98655

Uh oh!

Conversation

ArunmaniAlagarsamy2710 commented Oct 31, 2025

Uh oh!

jerome-pouiller left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Martinhoff-maker left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 5, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants