stm32hal: Fixes source address control #99352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch just formats the files eth_stm32_hal_v1 and the file stm32_hal_v2.c file before the real patch, otherwise the changes would be hard to read. Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>
The default configuration for all STM32 microcontrollers in HAL is to replace the ehternet MAC address with the address configured in replace address zero. In "modules/hal", Grep for: macDefaultConf.SourceAddrControl = ETH_SOURCEADDRESS_REPLACE_ADDR0; But this is a bad thing for bridging. Since Zephyr ethernet LL code always writes the source address, this patch has no impact on normal operation. And has the benefit of maintaining the source MAC address of bridged packets. Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>
zephyrbot
requested review from
ClaCodes,
FRASTM,
GeorgeCGV,
decsny,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
juickar,
lmajewski,
maass-hamburg,
mathieuchopstm and
pdgendt
|
Member
|
@mrjimenez Sorry we didn't had time to look at this point. Any reason to close that early ? |
Contributor
Author
|
Hi Erwan, I have already resubmitted it. There were too many compliance errors, I wanted to look carefully at what happened, because I had not seen them before submitting. I think I got my editor fixed now. The new pull request is this one: #99429 Regards, |
Member
|
@mrjimenez Ok, but next time, please keep the same PR. What you need to do is clean up your branch locally and force push once you're done. Otherwise there are too much PR created and it becomes confusing for reviewers. |
Contributor
Author
|
Ok, got it, sorry for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default configuration for all STM32 microcontrollers in HAL is
to replace the ehternet MAC address with the address configured in
replace address zero. In "modules/hal", Grep for:
macDefaultConf.SourceAddrControl = ETH_SOURCEADDRESS_REPLACE_ADDR0;
But this is a bad thing for bridging. Since Zephyr ethernet LL code
always writes the source address, this patch has no impact on normal
operation. And has the benefit of maintaining the source MAC address of
bridged packets.