scripts: set_assignee: get area object before before we get its collabs #99734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
added
the
Hotfix
zephyrbot
added
area: MAINTAINER File
area: Continuous Integration
size: XS
zephyrbot
requested review from
MaureenHelm,
fabiobaltieri,
kartben and
stephanosio
nashif
force-pushed
the
topic/scripts/set_assignee_2
branch
from
1d90c59 to
2f02ac2
Compare
pdgendt
approved these changes
Nov 20, 2025
In the manifest case, we were operating on a str instead of the area object. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
topic/scripts/set_assignee_2
branch
from
2f02ac2 to
43061ee
Compare
avisconti
approved these changes
Nov 20, 2025
tomi-font
approved these changes
Nov 20, 2025
| collab_per_path.update(_area.get_collaborators_for_path(changed_file.filename)) | ||
| area_match = maintainer_file.name2areas(_area) | ||
| if area_match: | ||
| _area_obj = area_match[0] |
Contributor
There was a problem hiding this comment.
Suggested change
| _area_obj = area_match[0] | |
| area_obj = area_match[0] |
?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the manifest case, we were operating on a str instead of the area object.
Signed-off-by: Anas Nashif anas.nashif@intel.com