Skip to content

scripts: set_assignee: get area object before before we get its collabs #99734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

scripts: set_assignee: get area object before before we get its collabs #99734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/ci/set_assignees.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,11 @@ def process_pr(gh, maintainer_file, number):
continue
parsed_areas = process_manifest(old_manifest_file=args.updated_manifest)
for _area in parsed_areas:
collab_per_path.update(_area.get_collaborators_for_path(changed_file.filename))
area_match = maintainer_file.name2areas(_area)
if area_match:
_area_obj = area_match[0]
Copy link
Contributor

@tomi-font tomi-font Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_area_obj = area_match[0]
area_obj = area_match[0]

?

collabs_for_area = _area_obj.get_collaborators_for_path(changed_file.filename)
collab_per_path.update(collabs_for_area)
areas.extend(area_match)
elif changed_file.filename in ['MAINTAINERS.yml']:
areas = maintainer_file.path2areas(changed_file.filename)
Expand Down
Loading