This repository was archived by the owner on Jan 24, 2022. It is now read-only.
Avoid transferring proxies to app on publish
#609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
approved these changes
Jan 28, 2019
facuspagnuolo
added
status:ready-to-merge
jbcarpanelli
deleted the
hotfix/avoid-transferring-proxies-to-app-on-publish
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing #588 and while implementing the migration between zosversion 2 and zosversion 2.2, I noticed that all owned proxy contracts were being transferred from
ProxyAdmintoApp, and that's not the intended behaviour, as proxies should be always owned by theProxyAdmin.