This repository was archived by the owner on Mar 16, 2026. It is now read-only.
feat: add Attribute_Tensor to protobuf schema#9
Merged
dndungu merged 1 commit intozerfoo:mainfrom Mar 3, 2026
Merged
Conversation
Add tensor oneof variant to Attribute message, enabling storage of tensor constants as node attributes. Required by zerfoo model builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attribute_Tensoroneof variant to Attribute message inzerfoo.protozerfoo.pb.gowith the new fieldWhy
PRs #7 and #8 merged as no-ops due to diverged histories (same commit messages, different SHAs/content). This PR is based directly on upstream main with a clean diff.
Without
Attribute_Tensor,zerfoo/zerfoofails to build:Test plan
Attribute_Tensoris present in mergedzerfoo.pb.gov0.3.0after mergezerfoo/zerfoogo.mod tozmf v0.3.0