chore(debug): remove FusedRMSNormGPU sub-step probes (E98 T98.3.2)#91
Merged
chore(debug): remove FusedRMSNormGPU sub-step probes (E98 T98.3.2)#91
Conversation
Probes were added in T98.2.2 to pin the corrupting sub-step inside FusedRMSNormGPU. Bug was found (devIn=0x0, pass-through aliasing issue) and fixed in T98.2.3. Probes no longer needed. Refs E98 T98.3.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strips the ZERFOO_GQA_DEBUG-gated probes from gpu_fused_rmsnorm.go added in T98.2.2. The bug those probes localized was fixed in T98.2.3 / PR #89.