fix: resolve NestJS GraphQL decorator parsing issue#61
Merged
Conversation
Fix bug where @Query/@mutation decorators without options object were not being detected: - @query(() => [Type]) now works correctly - @mutation(() => Type) now works correctly The issue was that decorators ending with ')' were incorrectly identified as "decorator only" and returning nil. Now they are treated as incomplete decorators that need extended content to find the function name. Add test cases for both patterns: - @query without options on same line - @query with options starting on same line Fixes Reddit user gi4c0's reported issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug where @Query/@mutation decorators without options object were not being detected:
The issue was that decorators ending with ')' were incorrectly identified as "decorator only" and returning nil. Now they are treated as incomplete decorators that need extended content to find the function name.
Add test cases for both patterns: