Skip to content

Fbe::Conclude#follow silently overwrites on second call, unlike by and as which raise Fbe::Error #565

Description

@morphqdd

What happens: In lib/fbe/conclude.rb, calling follow a second time silently replaces the previously configured list of properties to copy, with no error raised. The by method guards against double-invocation with raise(Fbe::Error, 'Query is already set') unless @query.nil?, and as does the same with raise(Fbe::Error, 'Label is already set') unless @label.nil?. The follow method has no such guard.

What should happen: follow should raise Fbe::Error when @follows is already non-empty (i.e. when called a second time), consistent with the defensive pattern used by by and as.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions