What happens: In lib/fbe/conclude.rb, calling follow a second time silently replaces the previously configured list of properties to copy, with no error raised. The by method guards against double-invocation with raise(Fbe::Error, 'Query is already set') unless @query.nil?, and as does the same with raise(Fbe::Error, 'Label is already set') unless @label.nil?. The follow method has no such guard.
What should happen: follow should raise Fbe::Error when @follows is already non-empty (i.e. when called a second time), consistent with the defensive pattern used by by and as.
What happens: In
lib/fbe/conclude.rb, callingfollowa second time silently replaces the previously configured list of properties to copy, with no error raised. Thebymethod guards against double-invocation withraise(Fbe::Error, 'Query is already set') unless @query.nil?, andasdoes the same withraise(Fbe::Error, 'Label is already set') unless @label.nil?. Thefollowmethod has no such guard.What should happen:
followshould raiseFbe::Errorwhen@followsis already non-empty (i.e. when called a second time), consistent with the defensive pattern used bybyandas.