fix(TimelockPolicy): correct ERC-7579 no-op detection encoding#48
Merged
leekt merged 1 commit intofix/tob-kernel-1from Feb 6, 2026
Merged
fix(TimelockPolicy): correct ERC-7579 no-op detection encoding#48leekt merged 1 commit intofix/tob-kernel-1from
leekt merged 1 commit intofix/tob-kernel-1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TOB-KERNEL-18 (Informational): No-op detection for ERC-7579 execute is inconsistent with actual encoding.
_isNoOpERC7579Executenow checks offset64(2 ABI head slots) instead of32decodeSingleusesabi.encodePacked(target, value, calldata)with no explicit length prefix. No-op detection now checksexecDataLength == 52(target 20B + value 32B, no inner calldata) instead of looking for a separatecalldataLengthwordAudit Reference
Test plan