feat: v2#52
Merged
Merged
Conversation
- suppress a lint warning
- renamed placeGTT to placeGtt - moved gtt related structs to a separate file
- move mf related structs to separate file - fix stray blank lines - use DEFAULT* constants
- use camel case for structs and methods - move structs to separate file - use DEFAULT* constants - convert magic numbers to constants
- move ws structs to separate file - convert magic numbers to constants - use DEFAULT* constants - remove commented out code
ajinasokan
reviewed
Oct 14, 2022
ajinasokan
reviewed
Oct 14, 2022
ajinasokan
reviewed
Oct 14, 2022
ajinasokan
reviewed
Oct 14, 2022
ajinasokan
reviewed
Oct 14, 2022
ajinasokan
reviewed
Oct 14, 2022
ajinasokan
reviewed
Oct 14, 2022
|
Removing the previous comment. |
ajinasokan
reviewed
Jan 11, 2023
bhumitattarde
force-pushed
the
v2
branch
2 times, most recently
from
dae1fbf to
a01ffea
Compare
Collaborator
Author
|
@rhnvrm @ajinasokan I don't have any more changes to make. Can we merge this if there's nothing to add? |
rhnvrm
approved these changes
Jan 16, 2023
| @@ -0,0 +1,2 @@ | |||
| # change column limit to 80 | |||
| 39cd0478af477b63ecc925fa8af8b0c82e4566e6 | |||
Member
There was a problem hiding this comment.
Is this file needed? What does this do?
Collaborator
Author
There was a problem hiding this comment.
git blame ignores changes made by commits mentioned in this file. Mainly used to prevent git blame from getting trashed during mass-formatting commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.