Problem: proxy is not typesafe #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 175
💛 - Coveralls |
sigiesec
reviewed
Mar 30, 2019
tests/socket.cpp
Outdated
| auto s1 = std::move(front); | ||
| auto s2 = std::move(back); | ||
| auto s3 = std::move(capture); | ||
| CHECK_THROWS(zmq::proxy(s1, s2, &s3)); |
Member
There was a problem hiding this comment.
Does this throw because of an ETERM error because the context is closed?
Shouldn't the CHECK_THROW be placed where the future is retrieved with get?
Member
Author
There was a problem hiding this comment.
Added explicit check for ETERM (constant available on windows?) and moved the check.
Solution: Add overloads to proxy and proxy_steerable taking socket_t objects
Member
|
Yes, it is defined under Windows as well! Thanks for the amendment :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Add overloads to proxy and proxy_steerable taking socket_t
objects
Additionally deprecate the void* overloads.